Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composite action to run buildout #99

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

gotcha
Copy link
Member

@gotcha gotcha commented Mar 24, 2023

Share GHA for other repositories

@gotcha gotcha marked this pull request as draft March 24, 2023 08:16
@gotcha gotcha self-assigned this Mar 24, 2023
@gotcha
Copy link
Member Author

gotcha commented Mar 24, 2023

I need to add guards/checks that will emit clear error messages when required files are missing.

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tried it, and it is work in progress, but seems like it should be fine.

But I already created a composite action last year. Did you check that?
https://github.com/collective/tox-action
Some details are different, for example I rely on tox and tox-gh-actions.

Comment on lines +8 to +9
github-token:
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say github-token should be optional. That is how it is in actions/setup-python

@gotcha
Copy link
Member Author

gotcha commented Apr 27, 2023

But I already created a composite action last year. Did you check that?
https://github.com/collective/tox-action

I did not know. I will definitely check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants