feat(#2758): z.string().ipRange() - add support for IP address range #3754
+400
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for guileless-rolypoly-866f8a ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This looks really good, I was just in need for this exact functionality. |
fredboutin
approved these changes
Nov 25, 2024
gdostie
approved these changes
Nov 25, 2024
|
I have nothing productive to contribute other than this would be really nice to have land in a release! |
|
Notice: Updated to follow the latest main branch. |
wataryooou
commented
Dec 14, 2024
Comment on lines
-762
to
-772
| function isValidCidr(ip: string, version?: IpVersion) { | ||
| if ((version === "v4" || !version) && ipv4CidrRegex.test(ip)) { | ||
| return true; | ||
| } | ||
| if ((version === "v6" || !version) && ipv6CidrRegex.test(ip)) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
[FYI] Just moved isValidCidr slightly up.
Comment on lines
+1087
to
1094
| } else if (check.kind === "ipRange") { | ||
| if (!isValidIPRange(input.data, check.cidr, check.version)) { | ||
| ctx = this._getOrReturnCtx(input, ctx); | ||
| addIssueToContext(ctx, { | ||
| validation: "jwt", | ||
| validation: "ipRange", | ||
| code: ZodIssueCode.invalid_string, | ||
| message: check.message, | ||
| }); |
There was a problem hiding this comment.
[FYI] I just rearranged the order so that all ip-related code is grouped together for better readability.
The internal code hasn't been changed 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #2758 adding IP Address range (CIDR) validation in zod string.
relate: #3820