FIX: emoji regex and tests #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for guileless-rolypoly-866f8a ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
joseph-lozano
commented
Feb 23, 2023
Comment on lines
-104
to
-129
| try { | ||
| url.parse("http://google.com"); | ||
| url.parse("https://google.com/asdf?asdf=ljk3lk4&asdf=234#asdf"); | ||
| expect(() => url.parse("asdf")).toThrow(); | ||
| expect(() => url.parse("https:/")).toThrow(); | ||
| expect(() => url.parse("[email protected]")).toThrow(); | ||
| } catch (err) {} |
There was a problem hiding this comment.
My original PR #2045 copied from this test, which had this empty catch, so I though it would also fix this in the follow up.
|
I'd fixed this with the somewhat hacky per-character validation, but this is definitely better. I was briefly worried that unicode property escapes might not be supported across all engines/runtimes (we've had issues with lookbehind assertions) but it seems to be. 👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so it was really late when Theo put the bounty up on the stupid emoji validation. It had some errors but got merged in while I was sleeping. This fixes some of the issues that were still on the PR. See #2045
It also turns out the regex can be made much nicer using unicode codepoints in the Regex, see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions/Unicode_Property_Escapes and https://unicode.org/reports/tr51/#Emoji_Properties