[pull] main from lynx-family:main#585
Merged
Merged
Conversation
…ses (#2464) ## Summary Two bugs that prevented `withLynxConfig()` from working in rstest environments: - **`@lynx-js/react-alias-rsbuild-plugin`**: `pluginReactAlias` only aliased `@lynx-js/react/jsx-runtime` and `@lynx-js/react/jsx-dev-runtime` inside layer-specific rules (`issuerLayer: BACKGROUND/MAIN_THREAD`). In rstest mode there are no layers, so JSX transformed by the testing loader—which emits `import { jsx } from '@lynx-js/react/jsx-runtime'`—could not be resolved (`Cannot find module '@lynx-js/react/jsx-runtime'`). Added global fallback aliases pointing to the background jsx-runtime. - **`@lynx-js/react-webpack-plugin` (testing loader)**: The testing loader forwarded `compat` directly to `transformReactLynxSync` without normalization. When `compat` is supplied as a partial object, the required `target` field is absent and the WASM transform throws `Error: Missing field 'target'`. Added the same normalization already present in `getCommonOptions` for the background/main-thread loaders. ## Test plan - [ ] `pnpm --filter @lynx-js/react-alias-rsbuild-plugin test` — new assertions verify `@lynx-js/react/jsx-runtime` and `@lynx-js/react/jsx-dev-runtime` are present as global aliases - [ ] `pnpm --filter @lynx-js/react-webpack-plugin test` — new `test/testing-loader.test.ts` covers partial compat (missing `target`), `compat: false`, and missing compat cases <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Ensure JSX runtime modules (@lynx-js/react/jsx-runtime and jsx-dev-runtime) resolve in testing/rstest mode via fallback aliasing. * Normalize partial compat configurations in the testing loader so required fields (e.g., target) are filled and WASM transform failures are prevented. * **Tests** * Added tests verifying loader behavior with partial, false, and omitted compat options and updated alias snapshots. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )