fix(sqlite): add allow_env_keys column to codebases schema + migration by Wirasm · Pull Request #988 · coleam00/Archon

Wirasm · 2026-04-08T12:05:30Z

Summary

PR #983 shipped the env-leak gate allow_env_keys column via PostgreSQL migrations but never updated packages/core/src/db/adapters/sqlite.ts, which has its own independent schema bootstrap path. Every SQLite database is broken since #983 landed — POST /api/codebases fails with table remote_agent_codebases has no column named allow_env_keys.

Cole's deployed server at archon-youtube.smartcode.diy is hitting this live — the VPS runs docker-compose with the SQLite default (no separate postgres service), so every "add project" returns 500.

Changes

Two surgical edits to packages/core/src/db/adapters/sqlite.ts, both copy-pasted from existing patterns in the file:

createSchema() — add allow_env_keys INTEGER DEFAULT 0 to the remote_agent_codebases CREATE TABLE block. Fresh databases get the column. SQLite has no true BOOLEAN — INTEGER with 0/1 matches the existing pattern used for hidden on conversations.
migrateColumns() — add a new idempotent try/catch block that PRAGMA-checks the codebases table for allow_env_keys and ALTERs it in if missing. Pattern matches the existing migration blocks for Conversations, Workflow runs, and Sessions columns. Existing databases get the column on next startup.

The JavaScript read path in db/codebases.ts and the clients already uses truthy checks (if (!codebase?.allow_env_keys)), which works for both SQLite integer (0/1) and JS boolean (false/true) storage. No other changes needed.

Test plan

bun test packages/core/src/db/adapters/sqlite.test.ts — all 68 tests pass
Diff scoped to one file, minimal blast radius
Pattern matches existing migration blocks (no new architectural choices)
After merge: Cole's deployed server picks up the fix via docker rebuild, migrateColumns() adds the column to the existing DB on next startup
After merge: cut v0.3.1 (includes fix(release): wire release workflow to scripts/build-binaries.sh (#986) #987 release workflow fix + this SQLite fix)

feat(env-leak-gate): polish sweep — CLI flag, config bypass, retroactive consent (#973) #983 — the PR that added the column for PostgreSQL but missed SQLite
bug(release): release workflow bypasses scripts/build-binaries.sh — v0.2.13 and v0.3.0 binaries are broken #986 / fix(release): wire release workflow to scripts/build-binaries.sh (#986) #987 — the release workflow fix (separate concern, already merged to dev)

Summary by CodeRabbit

Bug Fixes
- Added automatic database migration to include missing schema fields for managing environment keys in remote agent codebases, ensuring existing installations are properly updated.

PR #983 added the allow_env_keys consent bit via PostgreSQL migrations (migrations/000_combined.sql and migrations/021_*.sql) but did not update packages/core/src/db/adapters/sqlite.ts, which has its own independent schema bootstrap path. Result: every SQLite database has been broken since #983 landed: - Fresh installs: createSchema() creates remote_agent_codebases without the column, and POST /api/codebases fails on every call with "table remote_agent_codebases has no column named allow_env_keys". - Existing installs upgraded from v0.2.x: CREATE TABLE IF NOT EXISTS is a no-op on the existing table and migrateColumns() never adds the column, same failure. Cole's deployed server at archon-youtube.smartcode.diy hit this live — every "add project" request returned 500 because the VPS runs docker-compose with the SQLite default (no separate postgres service). Two surgical changes to packages/core/src/db/adapters/sqlite.ts: 1. createSchema(): add `allow_env_keys INTEGER DEFAULT 0` to the remote_agent_codebases CREATE TABLE block so fresh databases get the column. SQLite has no true BOOLEAN — INTEGER with 0/1 matches the existing pattern used for `hidden` on conversations. 2. migrateColumns(): add a new idempotent try/catch block that PRAGMA-checks the codebases table for `allow_env_keys` and ALTERs it in if missing. Pattern matches the existing migration blocks for Conversations, Workflow runs, and Sessions columns. The JavaScript read path in db/codebases.ts and the clients already uses truthy checks (`if (!codebase?.allow_env_keys)`), which works for both SQLite integer (0/1) and JS boolean (false/true) storage. No other changes needed. Fixes the live incident blocking Cole's demo and unblocks v0.3.1.

coderabbitai · 2026-04-08T12:05:47Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7a4f1339-9c5c-40e4-b794-619ca91d471c

📥 Commits

Reviewing files that changed from the base of the PR and between 9adc54a and a503a2d.

📒 Files selected for processing (1)

packages/core/src/db/adapters/sqlite.ts

📝 Walkthrough

Walkthrough

A database schema migration adds an allow_env_keys column to the remote_agent_codebases table in SQLite. The change includes both migration logic to detect and add the missing column and an updated schema definition with the new field defaulting to 0.

Changes

Cohort / File(s)	Summary
SQLite Schema Migration `packages/core/src/db/adapters/sqlite.ts`	Added `allow_env_keys INTEGER DEFAULT 0` column to `remote_agent_codebases` table with migration logic to check for the missing column, add it if absent, and log failures under `db.sqlite_migration_codebases_columns_failed`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A column hops into the database ground,
allow_env_keys, safely sound!
Migration magic checks if it's there,
With defaults of zero, handled with care.
The schema now blooms with this rabbit's delight! 🌿

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/sqlite-allow-env-keys-migration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

First post under a new docs site blog section. It's a post-mortem on the six bugs that broke every Archon binary release from v0.2.13 through v0.3.1: - #960 pino-pretty transport crash in compiled binaries - #961/#979 isBinaryBuild runtime detection fragility - #986/#987 release workflow bypassing scripts/build-binaries.sh - #988 SQLite schema missing allow_env_keys column - #990 Claude SDK cli.js path baked in at build time - #991/#992 env-leak gate firing on unregistered cwd paths Each bug masked the next. The test-release skill was the first thing that exercised the full chain (install the released binary on a clean machine, run real commands, verify end-to-end), and it found all six in sequence as the earlier layers got fixed. The post covers: - The bug onion metaphor and why it's particularly hard to debug - Each of the six bugs with root cause and fix PR - Why dev mode hid all of this - Why locally-built binaries passed all contributor tests but failed for every other user - The smoke test that finally broke the pattern - What changed in the release skill + what's still open - An honest 'note on blame' — the lesson is structural, not about being more careful Also adds a 'Blog' section to the Astro sidebar config so the new directory is discoverable. Positioned between Getting Started and Guides. Pre-post sanity check items for reviewer: - Factual accuracy of the bug-by-bug timeline - Whether to name the community contributor (leex279) explicitly or keep it generic - Whether the 'Note on blame' section is the right tone - Length (~3000 words) — fine for a post-mortem, could be trimmed to ~2000 for a shorter read

…logic (coleam00#988) Approve/reject/status/resume/abandon operations were duplicated between CLI and command-handler with subtle behavioral drift. This extracts the shared business logic into packages/core/src/operations/ so both callers are thin formatting adapters over a single implementation. Changes: - Create workflow-operations.ts with 6 shared operations - Create isolation-operations.ts with list/cleanup operations - Thin command-handler cases to delegate to operations - Thin CLI workflow/isolation commands to delegate to operations - Add 15 unit tests for operations layer - Update docs to reflect operations layer - Add TODO for future dispatchOrchestratorWorkflow extraction Fixes coleam00#988

coleam00#988) PR coleam00#983 added the allow_env_keys consent bit via PostgreSQL migrations (migrations/000_combined.sql and migrations/021_*.sql) but did not update packages/core/src/db/adapters/sqlite.ts, which has its own independent schema bootstrap path. Result: every SQLite database has been broken since coleam00#983 landed: - Fresh installs: createSchema() creates remote_agent_codebases without the column, and POST /api/codebases fails on every call with "table remote_agent_codebases has no column named allow_env_keys". - Existing installs upgraded from v0.2.x: CREATE TABLE IF NOT EXISTS is a no-op on the existing table and migrateColumns() never adds the column, same failure. Cole's deployed server at archon-youtube.smartcode.diy hit this live — every "add project" request returned 500 because the VPS runs docker-compose with the SQLite default (no separate postgres service). Two surgical changes to packages/core/src/db/adapters/sqlite.ts: 1. createSchema(): add `allow_env_keys INTEGER DEFAULT 0` to the remote_agent_codebases CREATE TABLE block so fresh databases get the column. SQLite has no true BOOLEAN — INTEGER with 0/1 matches the existing pattern used for `hidden` on conversations. 2. migrateColumns(): add a new idempotent try/catch block that PRAGMA-checks the codebases table for `allow_env_keys` and ALTERs it in if missing. Pattern matches the existing migration blocks for Conversations, Workflow runs, and Sessions columns. The JavaScript read path in db/codebases.ts and the clients already uses truthy checks (`if (!codebase?.allow_env_keys)`), which works for both SQLite integer (0/1) and JS boolean (false/true) storage. No other changes needed. Fixes the live incident blocking Cole's demo and unblocks v0.3.1.

…logic (coleam00#988) Approve/reject/status/resume/abandon operations were duplicated between CLI and command-handler with subtle behavioral drift. This extracts the shared business logic into packages/core/src/operations/ so both callers are thin formatting adapters over a single implementation. Changes: - Create workflow-operations.ts with 6 shared operations - Create isolation-operations.ts with list/cleanup operations - Thin command-handler cases to delegate to operations - Thin CLI workflow/isolation commands to delegate to operations - Add 15 unit tests for operations layer - Update docs to reflect operations layer - Add TODO for future dispatchOrchestratorWorkflow extraction Fixes coleam00#988

coleam00#988) PR coleam00#983 added the allow_env_keys consent bit via PostgreSQL migrations (migrations/000_combined.sql and migrations/021_*.sql) but did not update packages/core/src/db/adapters/sqlite.ts, which has its own independent schema bootstrap path. Result: every SQLite database has been broken since coleam00#983 landed: - Fresh installs: createSchema() creates remote_agent_codebases without the column, and POST /api/codebases fails on every call with "table remote_agent_codebases has no column named allow_env_keys". - Existing installs upgraded from v0.2.x: CREATE TABLE IF NOT EXISTS is a no-op on the existing table and migrateColumns() never adds the column, same failure. Cole's deployed server at archon-youtube.smartcode.diy hit this live — every "add project" request returned 500 because the VPS runs docker-compose with the SQLite default (no separate postgres service). Two surgical changes to packages/core/src/db/adapters/sqlite.ts: 1. createSchema(): add `allow_env_keys INTEGER DEFAULT 0` to the remote_agent_codebases CREATE TABLE block so fresh databases get the column. SQLite has no true BOOLEAN — INTEGER with 0/1 matches the existing pattern used for `hidden` on conversations. 2. migrateColumns(): add a new idempotent try/catch block that PRAGMA-checks the codebases table for `allow_env_keys` and ALTERs it in if missing. Pattern matches the existing migration blocks for Conversations, Workflow runs, and Sessions columns. The JavaScript read path in db/codebases.ts and the clients already uses truthy checks (`if (!codebase?.allow_env_keys)`), which works for both SQLite integer (0/1) and JS boolean (false/true) storage. No other changes needed. Fixes the live incident blocking Cole's demo and unblocks v0.3.1.

Wirasm merged commit a711347 into dev Apr 8, 2026

Wirasm deleted the fix/sqlite-allow-env-keys-migration branch April 8, 2026 12:05

This was referenced Apr 8, 2026

Release 0.3.1 #989

Merged

bug(env-leak-gate): pre-spawn check fires for unregistered cwd paths, blocks title generation and codebase-less workflows #991

Closed

feat(ci): add workflow run smoke test to release pipeline — the missing guardrail #996

Closed

Wirasm mentioned this pull request Apr 8, 2026

docs(blog): add retrospective on five broken releases before v0.3.2 #997

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(sqlite): add allow_env_keys column to codebases schema + migration#988

fix(sqlite): add allow_env_keys column to codebases schema + migration#988
Wirasm merged 1 commit intodevfrom
fix/sqlite-allow-env-keys-migration

Wirasm commented Apr 8, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 8, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Wirasm commented Apr 8, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Related

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Wirasm commented Apr 8, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 8, 2026 •

edited

Loading