fix(workflows): detect compiled binaries via execPath fallback by leex279 · Pull Request #963 · coleam00/Archon

leex279 · 2026-04-07T22:22:15Z

Summary

isBinaryBuild() only checked whether import.meta.dir lives under Bun's virtual FS (/$bunfs/ or B:\~BUN\). In CJS bytecode compiled binaries (bun build --compile with bytecode), import.meta.dir is empty/undefined and detection silently returned false.
Symptom in the released archon-linux-x64: installer prints Failed to read version: package.json not found (bad installation?) because the version command falls into the dev-mode getDevVersion() path that tries to read package.json from disk.
Adds a process.execPath basename check as a fallback: if execPath isn't bun/node, the process is a standalone compiled binary. Exported isCompiledExecPath() for testability.
Adds scripts/install-local.{ps1,sh} — local-file install harnesses for validating the install flow against a binary built from the current branch before cutting a release. Used to verify this fix end-to-end on Windows; the .sh variant is for Linux/Proxmox VM smoke testing.

Fixes #961

Test plan

bun test packages/workflows/src/defaults/bundled-defaults.test.ts — 18 pass, 0 fail (added 4 new tests for isCompiledExecPath covering bun/node interpreters and standalone binaries on Linux/macOS/Windows)
bun --filter @archon/workflows test — full suite green
bun --filter @archon/workflows type-check — clean
End-to-end smoke test on Windows: bun build --compile → install-local.ps1 → archon version reports Build: binary (was reporting dev path before).
Linux smoke test on Proxmox VM via install-local.sh (pending hardware access)
CI green on dev

`isBinaryBuild()` only checked whether `import.meta.dir` lives under Bun's virtual filesystem (`/$bunfs/` or `B:\~BUN\`). In CJS bytecode compiled binaries (`bun build --compile` with bytecode), `import.meta.dir` is empty or undefined, so detection silently returned `false`. Symptoms in the released `archon-linux-x64` binary: [WARN] Binary installed but version check failed: Error: Failed to read version: package.json not found (bad installation?) That error is only thrown by `getDevVersion()` in `packages/cli/src/commands/version.ts:33` — which the binary should never reach. Any other code branching on `isBinaryBuild()` (default workflow loading, embedded resources) was also taking the wrong path. Add a `process.execPath` basename check as a fallback: if execPath is neither `bun` nor `node`, the process is running as a standalone compiled binary. Exported `isCompiledExecPath()` for testability and added unit tests covering bun/node interpreters and standalone binaries on Linux, macOS, and Windows. Also adds `scripts/install-local.{ps1,sh}` — local-file install harnesses for validating the install flow against a binary built from the current branch before cutting a release. These were used to verify this fix end-to-end on Windows; the Linux harness is documented for testing on Proxmox / fresh Linux VMs. Fixes #961

coderabbitai · 2026-04-07T22:22:23Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3315ea7e-b192-4511-a595-be4f6710c2f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/binary-build-detection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…stream logger Replaces runtime detection of compiled binaries (env sniffing via import.meta.dir / process.execPath) with a build-time BUNDLED_IS_BINARY constant in @archon/paths/bundled-build.ts, rewritten by scripts/build-binaries.sh and restored on EXIT via a trap. Also rewrites @archon/paths/logger.ts to use pino-pretty as a destination stream instead of a worker-thread transport. The formatter now runs on the main thread, eliminating the require.resolve('pino-pretty') lookup that crashes inside Bun's /\$bunfs/ virtual filesystem in compiled binaries. The same code path runs in dev and binaries — no environment detection in the logger at all. isBinaryBuild() in @archon/workflows is kept as a one-line wrapper around BUNDLED_IS_BINARY so existing spyOn-based test mocking in loader.test.ts continues to work without modification. Closes #960 Closes #961 Closes #979 Supersedes #962 Supersedes #963 Co-Authored-By: leex279 <leex279@users.noreply.github.com>

@deprecated

…stream logger (#982) * fix(build): use build-time constants for binary detection and pretty stream logger Replaces runtime detection of compiled binaries (env sniffing via import.meta.dir / process.execPath) with a build-time BUNDLED_IS_BINARY constant in @archon/paths/bundled-build.ts, rewritten by scripts/build-binaries.sh and restored on EXIT via a trap. Also rewrites @archon/paths/logger.ts to use pino-pretty as a destination stream instead of a worker-thread transport. The formatter now runs on the main thread, eliminating the require.resolve('pino-pretty') lookup that crashes inside Bun's /\$bunfs/ virtual filesystem in compiled binaries. The same code path runs in dev and binaries — no environment detection in the logger at all. isBinaryBuild() in @archon/workflows is kept as a one-line wrapper around BUNDLED_IS_BINARY so existing spyOn-based test mocking in loader.test.ts continues to work without modification. Closes #960 Closes #961 Closes #979 Supersedes #962 Supersedes #963 Co-Authored-By: leex279 <leex279@users.noreply.github.com> * style(workflows): hoist BUNDLED_IS_BINARY import to top of file * fix(build,logger): harden pretty init and trap restore - logger: wrap pino-pretty init in try/catch and fall back to JSON so a broken TTY or missing peer can't crash module load. - build-binaries.sh: drop '2>/dev/null || true' from the EXIT trap so a failed bundled-build.ts restore is visible instead of silently leaving the dev tree with BUNDLED_IS_BINARY=true. - bundled-defaults: unmark isBinaryBuild() @deprecated and document why the wrapper is the intentional test seam (mock.module pollution in Bun). --------- Co-authored-by: leex279 <leex279@users.noreply.github.com>

Wirasm · 2026-04-08T09:03:56Z

Closing — superseded by #982 which replaces both this PR and #963 with a build-time constants refactor (e7789944 on dev).

Why the architectural redirect: the runtime detection approach needed two ANDed heuristics per package (import.meta.dir prefix + exec basename) because Bun has two compile modes (ESM vs CJS bytecode). Each heuristic has edge cases (Windows backslash, case sensitivity, renamed interpreters), the logic was duplicated across @archon/paths and @archon/workflows, and it would silently break on future Bun compile modes. #982 declares BUNDLED_IS_BINARY as a build-time constant written by scripts/build-binaries.sh — same pattern archon already uses for BUNDLED_VERSION. One source of truth, zero edge cases, no cross-package duplication.

For the logger specifically: #982 uses pino-pretty as a destination stream (synchronous, runs on main thread) instead of a worker-thread transport (which calls require.resolve inside /$bunfs/ and crashes). Same code path in dev and compiled binary — no environment detection at all.

Thank you @leex279 for catching the underlying bugs in #960/#961 and providing the initial fixes here. Your diagnosis drove the refactor; the new implementation credits you in its commit message. The install-local.{sh,ps1} scripts you added in #963 are useful QA infrastructure and were dropped from #982 to keep the diff focused on the fix itself — worth re-filing as a separate small PR if you want them back.

Reused worktrees were never checked against the configured baseBranch, so PRs could silently target the wrong base after a config change. Changes: - Add isAncestorOf() git helper using merge-base --is-ancestor - Add baseBranch field to IsolationHints for opt-in validation - Validate base branch in resolver checkExisting and findReusable paths - Add base branch warning in CLI worktree reuse path - Add tests for isAncestorOf and resolver base branch mismatch Fixes coleam00#963

@deprecated

…stream logger (coleam00#982) * fix(build): use build-time constants for binary detection and pretty stream logger Replaces runtime detection of compiled binaries (env sniffing via import.meta.dir / process.execPath) with a build-time BUNDLED_IS_BINARY constant in @archon/paths/bundled-build.ts, rewritten by scripts/build-binaries.sh and restored on EXIT via a trap. Also rewrites @archon/paths/logger.ts to use pino-pretty as a destination stream instead of a worker-thread transport. The formatter now runs on the main thread, eliminating the require.resolve('pino-pretty') lookup that crashes inside Bun's /\$bunfs/ virtual filesystem in compiled binaries. The same code path runs in dev and binaries — no environment detection in the logger at all. isBinaryBuild() in @archon/workflows is kept as a one-line wrapper around BUNDLED_IS_BINARY so existing spyOn-based test mocking in loader.test.ts continues to work without modification. Closes coleam00#960 Closes coleam00#961 Closes coleam00#979 Supersedes coleam00#962 Supersedes coleam00#963 Co-Authored-By: leex279 <leex279@users.noreply.github.com> * style(workflows): hoist BUNDLED_IS_BINARY import to top of file * fix(build,logger): harden pretty init and trap restore - logger: wrap pino-pretty init in try/catch and fall back to JSON so a broken TTY or missing peer can't crash module load. - build-binaries.sh: drop '2>/dev/null || true' from the EXIT trap so a failed bundled-build.ts restore is visible instead of silently leaving the dev tree with BUNDLED_IS_BINARY=true. - bundled-defaults: unmark isBinaryBuild() @deprecated and document why the wrapper is the intentional test seam (mock.module pollution in Bun). --------- Co-authored-by: leex279 <leex279@users.noreply.github.com>

Reused worktrees were never checked against the configured baseBranch, so PRs could silently target the wrong base after a config change. Changes: - Add isAncestorOf() git helper using merge-base --is-ancestor - Add baseBranch field to IsolationHints for opt-in validation - Validate base branch in resolver checkExisting and findReusable paths - Add base branch warning in CLI worktree reuse path - Add tests for isAncestorOf and resolver base branch mismatch Fixes coleam00#963

@deprecated

…stream logger (coleam00#982) * fix(build): use build-time constants for binary detection and pretty stream logger Replaces runtime detection of compiled binaries (env sniffing via import.meta.dir / process.execPath) with a build-time BUNDLED_IS_BINARY constant in @archon/paths/bundled-build.ts, rewritten by scripts/build-binaries.sh and restored on EXIT via a trap. Also rewrites @archon/paths/logger.ts to use pino-pretty as a destination stream instead of a worker-thread transport. The formatter now runs on the main thread, eliminating the require.resolve('pino-pretty') lookup that crashes inside Bun's /\$bunfs/ virtual filesystem in compiled binaries. The same code path runs in dev and binaries — no environment detection in the logger at all. isBinaryBuild() in @archon/workflows is kept as a one-line wrapper around BUNDLED_IS_BINARY so existing spyOn-based test mocking in loader.test.ts continues to work without modification. Closes coleam00#960 Closes coleam00#961 Closes coleam00#979 Supersedes coleam00#962 Supersedes coleam00#963 Co-Authored-By: leex279 <leex279@users.noreply.github.com> * style(workflows): hoist BUNDLED_IS_BINARY import to top of file * fix(build,logger): harden pretty init and trap restore - logger: wrap pino-pretty init in try/catch and fall back to JSON so a broken TTY or missing peer can't crash module load. - build-binaries.sh: drop '2>/dev/null || true' from the EXIT trap so a failed bundled-build.ts restore is visible instead of silently leaving the dev tree with BUNDLED_IS_BINARY=true. - bundled-defaults: unmark isBinaryBuild() @deprecated and document why the wrapper is the intentional test seam (mock.module pollution in Bun). --------- Co-authored-by: leex279 <leex279@users.noreply.github.com>

leex279 mentioned this pull request Apr 7, 2026

Compiled CLI binary crashes: pino-pretty transport unresolvable in bun --compile bundle #960

Closed

This was referenced Apr 8, 2026

feat(distribution): one-command web UI install via lazy-fetch from release tarball #978

Closed

fix(build): use build-time constants for binary detection and pretty stream logger (replaces #962/#963) #979

Closed

Wirasm mentioned this pull request Apr 8, 2026

fix(build): use build-time constants for binary detection and pretty stream logger #982

Merged

5 tasks

Wirasm mentioned this pull request Apr 8, 2026

fix(paths): skip pino-pretty transport in compiled binaries #962

Closed

5 tasks

Wirasm closed this Apr 8, 2026

This was referenced Apr 8, 2026

bug(release): release workflow bypasses scripts/build-binaries.sh — v0.2.13 and v0.3.0 binaries are broken #986

Closed

docs(blog): add retrospective on five broken releases before v0.3.2 #997

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(workflows): detect compiled binaries via execPath fallback#963

fix(workflows): detect compiled binaries via execPath fallback#963
leex279 wants to merge 1 commit intodevfrom
fix/binary-build-detection

leex279 commented Apr 7, 2026

Uh oh!

coderabbitai Bot commented Apr 7, 2026

Review skipped

Uh oh!

Wirasm commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

leex279 commented Apr 7, 2026

Summary

Test plan

Related

Uh oh!

coderabbitai Bot commented Apr 7, 2026

Review skipped

Uh oh!

Wirasm commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants