Skip to content

Pr/323#726

Closed
cristiZ1505 wants to merge 2 commits intocoleam00:mainfrom
cristiZ1505:pr/323
Closed

Pr/323#726
cristiZ1505 wants to merge 2 commits intocoleam00:mainfrom
cristiZ1505:pr/323

Conversation

@cristiZ1505
Copy link
Copy Markdown

Pull Request

Summary

Changes Made

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring

Affected Services

  • Frontend (React UI)
  • Server (FastAPI backend)
  • MCP Server (Model Context Protocol)
  • Agents (PydanticAI service)
  • Database (migrations/schema)
  • Docker/Infrastructure
  • Documentation site

Testing

  • All existing tests pass
  • Added new tests for new functionality
  • Manually tested affected user flows
  • Docker builds succeed for all services

Test Evidence

# Example: python -m pytest tests/
# Example: cd archon-ui-main && npm run test

Checklist

  • My code follows the service architecture patterns
  • If using an AI coding assistant, I used the CLAUDE.md rules
  • I have added tests that prove my fix/feature works
  • All new and existing tests pass locally
  • My changes generate no new warnings
  • I have updated relevant documentation
  • I have verified no regressions in existing features

Breaking Changes

Additional Notes

thilanga and others added 2 commits August 19, 2025 14:53
- Modified validate_supabase_url() to allow HTTP for local development
- HTTP is now allowed for localhost, 127.0.0.1, host.docker.internal, and 0.0.0.0
- HTTPS is still required for production/non-local environments
- Fixes server startup failure when using local Supabase with Docker
@Wirasm
Copy link
Copy Markdown
Collaborator

Wirasm commented Sep 22, 2025

thank you for this contribution @cristiZ1505 feel free to reopen this and fill the PR template

@Wirasm Wirasm closed this Sep 22, 2025
coleam00 added a commit that referenced this pull request Apr 7, 2026
…phan conversations (#726)

* fix(web): add cancel confirmation, surface rename errors, clean up orphan conversations (#708)

Workflow cancel button now shows a confirmation dialog before cancelling.
Conversation rename errors are displayed inline instead of silently logged.
Orphan conversations created before a workflow run failure are cleaned up.

Changes:
- WorkflowProgressCard: wrap Cancel button with AlertDialog confirmation
- ConversationItem: add renameError state and inline error display
- WorkflowInvoker: track conversationId and delete on runWorkflow failure
- WorkflowList: same orphan cleanup pattern as WorkflowInvoker

Fixes #708

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore: Auto-commit workflow artifacts (archon-fix-github-issue)

* fix(web): fix delete/rename ID mismatch, harden error handling (#708)

- Fix broken delete/rename: was sending database UUID instead of
  platform_conversation_id to API endpoints that expect platform IDs
- Hoist AlertDialog outside workflow status conditional to prevent
  unmounting mid-interaction when SSE status updates arrive
- Add console.warn for orphan conversation cleanup failures instead
  of silently swallowing errors (CLAUDE.md compliance)
- Scope orphan cleanup to only fire before runWorkflow starts to
  prevent deleting active conversations on client network errors
- Use err: unknown with instanceof guards on all catch blocks
- Surface useQuery errors with error UI instead of misleading empty state
- Re-open delete dialog on error so users see failure messages

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Tyone88 pushed a commit to Tyone88/Archon that referenced this pull request Apr 16, 2026
…phan conversations (coleam00#726)

* fix(web): add cancel confirmation, surface rename errors, clean up orphan conversations (coleam00#708)

Workflow cancel button now shows a confirmation dialog before cancelling.
Conversation rename errors are displayed inline instead of silently logged.
Orphan conversations created before a workflow run failure are cleaned up.

Changes:
- WorkflowProgressCard: wrap Cancel button with AlertDialog confirmation
- ConversationItem: add renameError state and inline error display
- WorkflowInvoker: track conversationId and delete on runWorkflow failure
- WorkflowList: same orphan cleanup pattern as WorkflowInvoker

Fixes coleam00#708

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore: Auto-commit workflow artifacts (archon-fix-github-issue)

* fix(web): fix delete/rename ID mismatch, harden error handling (coleam00#708)

- Fix broken delete/rename: was sending database UUID instead of
  platform_conversation_id to API endpoints that expect platform IDs
- Hoist AlertDialog outside workflow status conditional to prevent
  unmounting mid-interaction when SSE status updates arrive
- Add console.warn for orphan conversation cleanup failures instead
  of silently swallowing errors (CLAUDE.md compliance)
- Scope orphan cleanup to only fire before runWorkflow starts to
  prevent deleting active conversations on client network errors
- Use err: unknown with instanceof guards on all catch blocks
- Surface useQuery errors with error UI instead of misleading empty state
- Re-open delete dialog on error so users see failure messages

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
joaobmonteiro pushed a commit to joaobmonteiro/Archon that referenced this pull request Apr 26, 2026
…phan conversations (coleam00#726)

* fix(web): add cancel confirmation, surface rename errors, clean up orphan conversations (coleam00#708)

Workflow cancel button now shows a confirmation dialog before cancelling.
Conversation rename errors are displayed inline instead of silently logged.
Orphan conversations created before a workflow run failure are cleaned up.

Changes:
- WorkflowProgressCard: wrap Cancel button with AlertDialog confirmation
- ConversationItem: add renameError state and inline error display
- WorkflowInvoker: track conversationId and delete on runWorkflow failure
- WorkflowList: same orphan cleanup pattern as WorkflowInvoker

Fixes coleam00#708

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore: Auto-commit workflow artifacts (archon-fix-github-issue)

* fix(web): fix delete/rename ID mismatch, harden error handling (coleam00#708)

- Fix broken delete/rename: was sending database UUID instead of
  platform_conversation_id to API endpoints that expect platform IDs
- Hoist AlertDialog outside workflow status conditional to prevent
  unmounting mid-interaction when SSE status updates arrive
- Add console.warn for orphan conversation cleanup failures instead
  of silently swallowing errors (CLAUDE.md compliance)
- Scope orphan cleanup to only fire before runWorkflow starts to
  prevent deleting active conversations on client network errors
- Use err: unknown with instanceof guards on all catch blocks
- Surface useQuery errors with error UI instead of misleading empty state
- Re-open delete dialog on error so users see failure messages

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants