Skip to content

feat: implement reusable useAutoSave hook for inline editing (#694) #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonahgabriel wants to merge 5 commits into from
Closed

feat: implement reusable useAutoSave hook for inline editing (#694) #724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d45a077
feat: implement generic useAutoSave hook with TypeScript support and …
Sep 20, 2025
6914ca5
fix: resolve timing issues in useAutoSave tests
Sep 20, 2025
03a30a4
feat: implement reusable useAutoSave hook for inline editing (#694)
jonahgabriel Sep 20, 2025
f4065aa
feat: remove Knowledge-specific useKnowledgeAutoSave wrapper
jonahgabriel Sep 23, 2025
5fef8fe
fix: address CodeRabbit feedback on PR #724
jonahgabriel Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .codanna/index/tantivy/.managed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
["meta.json"]
342 changes: 342 additions & 0 deletions .codanna/index/tantivy/meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,342 @@
{
"index_settings": {
"docstore_compression": "lz4",
"docstore_blocksize": 16384
},
"segments": [],
"schema": [
Comment on lines +1 to +7
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

🧩 Analysis chain

Avoid committing generated Tantivy index artifacts

meta.json looks like a runtime‑generated Tantivy index metadata file (opstamp, segments). Committing this will create constant churn and merge conflicts. Prefer ignoring .codanna/index/** and generating the index at build/runtime. If you intend to version a schema, extract a stable schema.json only.

Apply ignore rules and remove the tracked file:

# .gitignore
+/.codanna/index/
+/.codanna/**

Run to verify ignore and tracked files:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Checking for existing ignore rules related to .codanna ..."
rg -n "codanna|tantivy" -g .gitignore -C1 || true

echo
echo "Listing tracked files under .codanna ..."
git ls-files | rg '^\.codanna/' || echo "No tracked files under .codanna"

echo
echo "Suggested next steps if files are tracked:"
echo "  git rm -r --cached .codanna && git commit -m 'chore: stop tracking generated codanna index artifacts'"

Length of output: 318

Remove generated Tantivy index artifacts and ignore .codanna/

Tracked files: .codanna/index/tantivy/.managed.json, .codanna/index/tantivy/meta.json — these are runtime-generated; add ignore rules and stop tracking them.

# .gitignore
+/.codanna/index/
+/.codanna/**

Commands to untrack and commit:
git rm -r --cached .codanna
git commit -m "chore: stop tracking generated codanna index artifacts"

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In .codanna/index/tantivy/meta.json lines 1-7: these and
.codanna/index/tantivy/.managed.json are generated runtime artifacts and must be
removed from version control and ignored; update .gitignore to add a rule for
.codanna/ (or .codanna/index/tantivy/), run git rm -r --cached .codanna to
untrack the files, commit with the suggested message (e.g., "chore: stop
tracking generated codanna index artifacts"), and verify the generated files
remain locally but are no longer in the repo.

{
"name": "doc_type",
"type": "text",
"options": {
"indexing": {
"record": "basic",
"fieldnorms": true,
"tokenizer": "raw"
},
"stored": true,
"fast": true
}
},
{
"name": "symbol_id",
"type": "u64",
"options": {
"indexed": true,
"fieldnorms": false,
"fast": true,
"stored": true
}
},
{
"name": "file_path",
"type": "text",
"options": {
"indexing": {
"record": "basic",
"fieldnorms": true,
"tokenizer": "raw"
},
"stored": true,
"fast": false
}
},
{
"name": "line_number",
"type": "u64",
"options": {
"indexed": false,
"fieldnorms": false,
"fast": true,
"stored": true
}
},
{
"name": "column",
"type": "u64",
"options": {
"indexed": false,
"fieldnorms": false,
"fast": false,
"stored": true
}
},
{
"name": "name",
"type": "text",
"options": {
"indexing": {
"record": "position",
"fieldnorms": true,
"tokenizer": "default"
},
"stored": true,
"fast": false
}
},
{
"name": "doc_comment",
"type": "text",
"options": {
"indexing": {
"record": "position",
"fieldnorms": true,
"tokenizer": "default"
},
"stored": true,
"fast": false
}
},
{
"name": "signature",
"type": "text",
"options": {
"indexing": {
"record": "position",
"fieldnorms": true,
"tokenizer": "default"
},
"stored": true,
"fast": false
}
},
{
"name": "context",
"type": "text",
"options": {
"indexing": {
"record": "position",
"fieldnorms": true,
"tokenizer": "default"
},
"stored": true,
"fast": false
}
},
{
"name": "module_path",
"type": "text",
"options": {
"indexing": {
"record": "basic",
"fieldnorms": true,
"tokenizer": "raw"
},
"stored": true,
"fast": false
}
},
{
"name": "kind",
"type": "text",
"options": {
"indexing": {
"record": "basic",
"fieldnorms": true,
"tokenizer": "raw"
},
"stored": true,
"fast": false
}
},
{
"name": "visibility",
"type": "u64",
"options": {
"indexed": false,
"fieldnorms": false,
"fast": false,
"stored": true
}
},
{
"name": "scope_context",
"type": "text",
"options": {
"indexing": {
"record": "basic",
"fieldnorms": true,
"tokenizer": "raw"
},
"stored": true,
"fast": false
}
},
{
"name": "language",
"type": "text",
"options": {
"indexing": {
"record": "basic",
"fieldnorms": true,
"tokenizer": "raw"
},
"stored": true,
"fast": true
}
},
{
"name": "from_symbol_id",
"type": "u64",
"options": {
"indexed": true,
"fieldnorms": false,
"fast": true,
"stored": true
}
},
{
"name": "to_symbol_id",
"type": "u64",
"options": {
"indexed": true,
"fieldnorms": false,
"fast": true,
"stored": true
}
},
{
"name": "relation_kind",
"type": "text",
"options": {
"indexing": {
"record": "basic",
"fieldnorms": true,
"tokenizer": "raw"
},
"stored": true,
"fast": true
}
},
{
"name": "relation_weight",
"type": "f64",
"options": {
"indexed": false,
"fieldnorms": false,
"fast": false,
"stored": true
}
},
{
"name": "relation_line",
"type": "u64",
"options": {
"indexed": false,
"fieldnorms": false,
"fast": false,
"stored": true
}
},
{
"name": "relation_column",
"type": "u64",
"options": {
"indexed": false,
"fieldnorms": false,
"fast": false,
"stored": true
}
},
{
"name": "relation_context",
"type": "text",
"options": {
"indexing": {
"record": "position",
"fieldnorms": true,
"tokenizer": "default"
},
"stored": true,
"fast": false
}
},
{
"name": "file_id",
"type": "u64",
"options": {
"indexed": true,
"fieldnorms": false,
"fast": true,
"stored": true
}
},
{
"name": "file_hash",
"type": "text",
"options": {
"indexing": {
"record": "basic",
"fieldnorms": true,
"tokenizer": "raw"
},
"stored": true,
"fast": false
}
},
{
"name": "file_timestamp",
"type": "u64",
"options": {
"indexed": false,
"fieldnorms": false,
"fast": true,
"stored": true
}
},
{
"name": "meta_key",
"type": "text",
"options": {
"indexing": {
"record": "basic",
"fieldnorms": true,
"tokenizer": "raw"
},
"stored": true,
"fast": true
}
},
{
"name": "meta_value",
"type": "u64",
"options": {
"indexed": false,
"fieldnorms": false,
"fast": true,
"stored": true
}
},
{
"name": "cluster_id",
"type": "u64",
"options": {
"indexed": false,
"fieldnorms": false,
"fast": true,
"stored": true
}
},
{
"name": "vector_id",
"type": "u64",
"options": {
"indexed": false,
"fieldnorms": false,
"fast": true,
"stored": true
}
},
{
"name": "has_vector",
"type": "u64",
"options": {
"indexed": false,
"fieldnorms": false,
"fast": true,
"stored": true
}
}
],
"opstamp": 0
}
Loading