1.将python镜像升级到python:3.13-slim#592
Closed
ssiagu wants to merge 1 commit intocoleam00:mainfrom
Closed
Conversation
2.将ollama设置为自定义提供商。API_key复用open ai的。
|
Caution Review failedThe pull request is closed. WalkthroughBase Python images in Dockerfiles were upgraded to 3.13. Credential lookup now maps the Ollama provider to OPENAI_API_KEY. The Ollama client initialization passes a dynamic API key instead of a fixed "ollama" string. No public interfaces changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant S as Server
participant CS as CredentialService
participant ENV as Env Vars
participant LPS as LLMProviderService
participant OA as OpenAI Async Client (Ollama base_url)
S->>CS: _get_provider_api_key(provider="ollama")
CS->>ENV: Read OPENAI_API_KEY
ENV-->>CS: api_key (may be empty)
CS-->>S: api_key
S->>LPS: get_llm_client(provider="ollama", api_key)
LPS->>OA: new AsyncOpenAI(base_url=ollama_url, api_key=api_key)
OA-->>LPS: client instance
LPS-->>S: ollama client
note over LPS,OA: If api_key absent, client may proceed with dummy/no key per config
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
coleam00
pushed a commit
that referenced
this pull request
Apr 7, 2026
* Fix: extractOwnerRepo silently produces 'undefined' path segments (#586) When repoPath has fewer than 2 non-empty segments (e.g. /repo), both the inline extraction in createWorktreeForIssue and the private method in WorktreeProvider silently returned undefined for the owner segment, causing path.join() to produce paths like <base>/undefined/<repo>/<branch>. Changes: - Add exported extractOwnerRepo() to @archon/git with parts.length < 2 guard - Use extractOwnerRepo() in createWorktreeForIssue (replaces inline logic) - Export extractOwnerRepo from @archon/git index - Delegate WorktreeProvider.extractOwnerRepo() to the shared @archon/git function - Add tests for the error path in both @archon/git and @archon/isolation Fixes #586 * fix: address review findings from PR #592 - Use toRepoPath() / RepoPath casts in extractOwnerRepo tests for type consistency - Add boundary test for exactly-2-segment path in extractOwnerRepo - Add Windows-style path test for extractOwnerRepo - Add 'cannot extract owner/repo' pattern to classifyIsolationError for cleaner user messages
Tyone88
pushed a commit
to Tyone88/Archon
that referenced
this pull request
Apr 16, 2026
…leam00#592) * Fix: extractOwnerRepo silently produces 'undefined' path segments (coleam00#586) When repoPath has fewer than 2 non-empty segments (e.g. /repo), both the inline extraction in createWorktreeForIssue and the private method in WorktreeProvider silently returned undefined for the owner segment, causing path.join() to produce paths like <base>/undefined/<repo>/<branch>. Changes: - Add exported extractOwnerRepo() to @archon/git with parts.length < 2 guard - Use extractOwnerRepo() in createWorktreeForIssue (replaces inline logic) - Export extractOwnerRepo from @archon/git index - Delegate WorktreeProvider.extractOwnerRepo() to the shared @archon/git function - Add tests for the error path in both @archon/git and @archon/isolation Fixes coleam00#586 * fix: address review findings from PR coleam00#592 - Use toRepoPath() / RepoPath casts in extractOwnerRepo tests for type consistency - Add boundary test for exactly-2-segment path in extractOwnerRepo - Add Windows-style path test for extractOwnerRepo - Add 'cannot extract owner/repo' pattern to classifyIsolationError for cleaner user messages
joaobmonteiro
pushed a commit
to joaobmonteiro/Archon
that referenced
this pull request
Apr 26, 2026
…leam00#592) * Fix: extractOwnerRepo silently produces 'undefined' path segments (coleam00#586) When repoPath has fewer than 2 non-empty segments (e.g. /repo), both the inline extraction in createWorktreeForIssue and the private method in WorktreeProvider silently returned undefined for the owner segment, causing path.join() to produce paths like <base>/undefined/<repo>/<branch>. Changes: - Add exported extractOwnerRepo() to @archon/git with parts.length < 2 guard - Use extractOwnerRepo() in createWorktreeForIssue (replaces inline logic) - Export extractOwnerRepo from @archon/git index - Delegate WorktreeProvider.extractOwnerRepo() to the shared @archon/git function - Add tests for the error path in both @archon/git and @archon/isolation Fixes coleam00#586 * fix: address review findings from PR coleam00#592 - Use toRepoPath() / RepoPath casts in extractOwnerRepo tests for type consistency - Add boundary test for exactly-2-segment path in extractOwnerRepo - Add Windows-style path test for extractOwnerRepo - Add 'cannot extract owner/repo' pattern to classifyIsolationError for cleaner user messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.将ollama设置为自定义提供商。API_key复用open ai的。
Pull Request
Summary
Changes Made
Type of Change
Affected Services
Testing
Test Evidence
Checklist
Breaking Changes
Additional Notes
Summary by CodeRabbit
Chores
Bug Fixes