Skip to content

Fix Stage 1 workflow permissions for external PR reviews#327

Closed
Wirasm wants to merge 1 commit intomainfrom
feature/external-pr-claude-review
Closed

Fix Stage 1 workflow permissions for external PR reviews#327
Wirasm wants to merge 1 commit intomainfrom
feature/external-pr-claude-review

Conversation

@Wirasm
Copy link
Copy Markdown
Collaborator

@Wirasm Wirasm commented Aug 19, 2025

Summary

Fixes the Stage 1 workflow failing when trying to post status comments on PRs.

Changes Made

  • Updated permissions to allow writing PR comments
  • Added error handling for comment posting with try-catch
  • Made comment posting continue on error to not block Stage 2
  • Added informative console logging for debugging

Issue Fixed

The workflow was failing with "Resource not accessible by integration" error when trying to post comments because it only had read permissions.

Testing

This will allow the workflow to complete successfully even if comment posting fails in certain permission scenarios, ensuring Stage 2 can still run.

- Grant pull-requests write permission for posting comments
- Add try-catch error handling for comment posting
- Continue workflow even if comment posting fails
- Add informative console messages for debugging
@Wirasm
Copy link
Copy Markdown
Collaborator Author

Wirasm commented Aug 19, 2025

wont implement

@Wirasm Wirasm closed this Aug 19, 2025
@Wirasm Wirasm deleted the feature/external-pr-claude-review branch August 19, 2025 08:20
POWERFULMOVES added a commit to POWERFULMOVES/PMOVES-Archon that referenced this pull request Feb 12, 2026
…am00#327)

* fix(ui): accessibility improvements and Tailwind JIT compliance

- Add skip link for keyboard navigation (WCAG 2.1 AA)
- Add id="main-content" to DashboardShell main element
- Fix dynamic Tailwind class generation in services/page.tsx:
  - Replace `tag tag-${color}` with TAG_CLASSES lookup
  - Replace complex ternary bg class with ICON_BG_CLASSES lookup
  - Extract colorClasses to module-level BORDER_CLASSES constant
- Fix misleading comment in globals.css (heading-serif uses sans-serif font)

Fixes accessibility and design consistency issues from PR coleam00#324 review.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: remove focus:outline-none for WCAG 2.4.7 compliance

Skip link now has visible focus outline (focus:outline-2) instead of
hiding it. The cyan background provides primary feedback, but the
outline ensures compliance with WCAG 2.4.7 Focus Visible requirement.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(a11y): improve skip link accessibility compliance

- Add focus:outline-void for visible outline against cyan background
- Add tabIndex={-1} to main-content for proper skip link focus
- Correct WCAG reference: SC 2.4.1 Bypass Blocks is Level A, not AA
- Add cross-reference comment linking skip target to layout.tsx

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Codex Agent <codex-agent@example.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
POWERFULMOVES pushed a commit to POWERFULMOVES/PMOVES-Archon that referenced this pull request Feb 12, 2026
- Add UI Development Checklist section to CLAUDE.md with security,
  privacy, accessibility, and code quality guidelines
- Create ui-patterns.md context doc with error handling, authentication,
  and accessibility patterns from PRs coleam00#325, coleam00#326, coleam00#327
- Document CodeRabbit review learnings for future reference

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
coleam00 pushed a commit that referenced this pull request Apr 7, 2026
Add entries for:
- 0.2.1 (2026-01-21): Hono migration, CLI binary distribution, runtime defaults
- 0.2.2 (2026-01-22): CLI documentation, repo ownership migration, Dockerfile fix
Tyone88 pushed a commit to Tyone88/Archon that referenced this pull request Apr 16, 2026
Add entries for:
- 0.2.1 (2026-01-21): Hono migration, CLI binary distribution, runtime defaults
- 0.2.2 (2026-01-22): CLI documentation, repo ownership migration, Dockerfile fix
joaobmonteiro pushed a commit to joaobmonteiro/Archon that referenced this pull request Apr 26, 2026
Add entries for:
- 0.2.1 (2026-01-21): Hono migration, CLI binary distribution, runtime defaults
- 0.2.2 (2026-01-22): CLI documentation, repo ownership migration, Dockerfile fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant