feat(codex): support workflow skills #1534
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| import { afterEach, beforeEach, describe, expect, spyOn, test } from 'bun:test'; | ||
| import { mkdir, mkdtemp, rm, writeFile } from 'fs/promises'; | ||
| import { tmpdir } from 'os'; | ||
| import { join } from 'path'; | ||
| import { clearConfigCache } from '@archon/core'; | ||
| import { validateWorkflowsCommand } from './validate'; | ||
|
|
||
| const tempDirs: string[] = []; | ||
| let consoleLogSpy: ReturnType<typeof spyOn>; | ||
| let originalArchonHome: string | undefined; | ||
| let originalDefaultAssistant: string | undefined; | ||
|
|
||
| async function makeTempDir(prefix: string): Promise<string> { | ||
| const dir = await mkdtemp(join(tmpdir(), prefix)); | ||
| tempDirs.push(dir); | ||
| return dir; | ||
| } | ||
|
|
||
| beforeEach(async () => { | ||
| originalArchonHome = process.env.ARCHON_HOME; | ||
| originalDefaultAssistant = process.env.DEFAULT_AI_ASSISTANT; | ||
| process.env.ARCHON_HOME = await makeTempDir('archon-cli-home-'); | ||
| delete process.env.DEFAULT_AI_ASSISTANT; | ||
| clearConfigCache(); | ||
| consoleLogSpy = spyOn(console, 'log').mockImplementation(() => {}); | ||
| }); | ||
|
|
||
| afterEach(async () => { | ||
| consoleLogSpy.mockRestore(); | ||
| if (originalArchonHome === undefined) { | ||
| delete process.env.ARCHON_HOME; | ||
| } else { | ||
| process.env.ARCHON_HOME = originalArchonHome; | ||
| } | ||
| if (originalDefaultAssistant === undefined) { | ||
| delete process.env.DEFAULT_AI_ASSISTANT; | ||
| } else { | ||
| process.env.DEFAULT_AI_ASSISTANT = originalDefaultAssistant; | ||
| } | ||
| clearConfigCache(); | ||
| for (const dir of tempDirs.splice(0)) { | ||
| await rm(dir, { recursive: true, force: true }); | ||
| } | ||
| }); | ||
|
|
||
| describe('validateWorkflowsCommand', () => { | ||
| test('uses configured Codex skillRoots for workflows that rely on the default provider', async () => { | ||
| const repo = await makeTempDir('archon-validate-skills-'); | ||
| const skillRoot = join(repo, 'custom-skills'); | ||
| await mkdir(join(skillRoot, 'alpha'), { recursive: true }); | ||
| await writeFile(join(skillRoot, 'alpha', 'SKILL.md'), '# Alpha\n'); | ||
| await mkdir(join(repo, '.archon', 'workflows'), { recursive: true }); | ||
| await writeFile( | ||
| join(repo, '.archon', 'workflows', 'codex-skills.yaml'), | ||
| ` | ||
| name: codex-skills | ||
| description: test | ||
| nodes: | ||
| - id: review | ||
| prompt: Review | ||
| skills: [alpha] | ||
| ` | ||
| ); | ||
| await writeFile( | ||
| join(repo, '.archon', 'config.yaml'), | ||
| ` | ||
| assistant: codex | ||
| assistants: | ||
| codex: | ||
| skillRoots: | ||
| - ${skillRoot} | ||
| defaults: | ||
| loadDefaultCommands: false | ||
| loadDefaultWorkflows: false | ||
| ` | ||
| ); | ||
|
|
||
| const exitCode = await validateWorkflowsCommand(repo, undefined, true); | ||
|
|
||
| expect(exitCode).toBe(0); | ||
| expect(consoleLogSpy).toHaveBeenCalledTimes(1); | ||
| const output = JSON.parse(consoleLogSpy.mock.calls[0]?.[0] as string) as { | ||
| summary: { errors: number }; | ||
| }; | ||
| expect(output.summary.errors).toBe(0); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validateWorkflowsCommandnow awaitsloadConfig(cwd)without a fallback, so a malformed or unreadable global/repo config causes the command to throw before discovery/validation runs. This regresses prior behavior where config-load failures were tolerated (viadiscoverWorkflowsWithConfig’s internal try/catch) and users could still validate workflows with defaults.Useful? React with 👍 / 👎.