fix(core/test): split connection.test.ts from DB-test batch to avoid mock pollution

[Wirasm]

Summary

packages/core/src/db/messages.test.ts:9 uses mock.module('./connection', ...) at module-load time. Per CLAUDE.md test-isolation rules and oven-sh/bun#7823, mock.module() is process-global and irreversible — mock.restore() does NOT undo it.

When Bun pre-loads all test files in a single batch invocation, the mock replaces the real ./connection module before connection.test.ts even runs. So getDatabaseType() returns the mocked 'postgresql' regardless of DATABASE_URL, and three tests fail:

• connection > getDatabaseType > should return sqlite when DATABASE_URL is not set
• connection > getDatabaseType > should return sqlite when DATABASE_URL is empty string
• connection > getDatabaseType > should not initialize database connection

These are pre-existing on dev — I hit them while working on an unrelated branch and traced the root cause.

Fix

One-line package.json edit: move src/db/connection.test.ts into its own bun test invocation, immediately after postgres.test.ts, before the shared DB/utils/config/state batch that contains messages.test.ts.

Follows the same isolation pattern already applied to command-handler.test.ts, clone.test.ts, postgres.test.ts, and path-validation.test.ts.

Test plan

• bun --filter @archon/core test — all 355 tests pass, 0 fail (previously 3 fail)
• bun run validate — fully green end-to-end

Summary by CodeRabbit

• Chores
  • Reorganized test execution order in the build configuration.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c6318f0e-2c38-4e3a-aae7-e21757e53371

📥 Commits

Reviewing files that changed from the base of the PR and between bed36ca and 889ffca.

📒 Files selected for processing (1)

• packages/core/package.json

---

📝 Walkthrough

Walkthrough

The test npm script in packages/core/package.json was reordered to segment the database test execution differently. The change reorganizes how bun test commands are chained together, separating src/db/adapters/sqlite.test.ts from subsequent database tests to prevent test isolation issues.

Changes

Cohort / File(s)	Summary
Test Script Configuration packages/core/package.json	Reordered test command chain to segment database test execution separately, addressing test state pollution between bun test runs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

• Migrate mock.module() to spyOn() in @archon/core test files #966: Addresses the same bun mock.module() pollution issue in database tests by reordering test execution through a process-level workaround in the package.json test script.

Poem

🐰 A hop, a skip, a script so neat,
Tests now dance in separate beat,
No more tangled mock.module mess,
Bun runs clean—a fuzzy success! ✨

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/connection-test-mock-pollution

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}