Skip to content

fix: override axios to ^1.15.0 for CVE-2025-62718#1153

Closed
stefans71 wants to merge 1 commit intocoleam00:devfrom
stefans71:fix/axios-cve-2025-62718
Closed

fix: override axios to ^1.15.0 for CVE-2025-62718#1153
stefans71 wants to merge 1 commit intocoleam00:devfrom
stefans71:fix/axios-cve-2025-62718

Conversation

@stefans71
Copy link
Copy Markdown
Contributor

@stefans71 stefans71 commented Apr 13, 2026

Summary

  • Adds "axios": "^1.15.0" to overrides in root package.json to fix CVE-2025-62718
  • Axios is a transitive dependency via @slack/bolt (^1.12.0) and @slack/web-api (^1.13.5) — both already accept >=1.15.0 via their semver ranges
  • The CVE allows bypassing NO_PROXY rules via hostname normalization, potentially leading to SSRF

Closes #1053

Test plan

  • bun install resolves axios to 1.15.0 in lockfile
  • bun run type-check passes
  • bun run validate passes (CI)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated package dependency override configurations for improved stability and compatibility.

Axios is a transitive dependency via @slack/bolt and @slack/web-api.
The lockfile resolved to 1.13.6, which is vulnerable to NO_PROXY
hostname normalization bypass (SSRF risk). Both Slack packages
already accept ^1.15.0 via their semver ranges, so adding an
override is sufficient.

Closes coleam00#1053

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6dd510fc-bdd2-459c-b365-0fc82a975390

📥 Commits

Reviewing files that changed from the base of the PR and between eb75ab6 and c4be95a.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

Updated package.json overrides configuration to pin axios to version ^1.15.0 and reformatted the test-exclude override entry. No exported or public code entities were modified.

Changes

Cohort / File(s) Summary
Dependency Overrides
package.json
Added axios dependency override pinned to ^1.15.0; reformatted test-exclude override entry for consistency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Through dependency fields I hop and bound,
Axios patched, a fix profound,
CVE-2025 now sealed so tight,
Proxy rules shine bright,
Security strengthened with delight! 🔐

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides essential context (CVE details, dependency chain, security implications) and includes test evidence, but omits most structured sections from the template. Add risk assessment (low/medium/high), module labeling, change metadata, architecture context, and rollback plan to align with repository template standards.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the main change: overriding axios to a patched version to address CVE-2025-62718.
Linked Issues check ✅ Passed The PR successfully addresses all primary requirements from issue #1053: updates axios to a non-vulnerable version compatible with existing dependencies and prevents NO_PROXY bypass vulnerabilities.
Out of Scope Changes check ✅ Passed All changes are directly scoped to resolving CVE-2025-62718; only package.json overrides were modified with no unrelated alterations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Wirasm
Copy link
Copy Markdown
Collaborator

Wirasm commented Apr 21, 2026

Thanks for catching this, @stefans71 — closing and re-opening on current `dev` with full credit to you. Your branch is 8 days behind `dev` and `bun.lock` conflicts on unrelated version bumps (0.3.5 → 0.3.6), so a one-line fix is cleaner re-done on a fresh branch than rebased. Crediting via `Co-authored-by:` on the replacement commit.

Follow-up PR is inbound — will link it here.

@Wirasm Wirasm closed this Apr 21, 2026
Wirasm added a commit that referenced this pull request Apr 22, 2026
…1330)

axios <1.15.0 can be coerced to bypass NO_PROXY rules via hostname
normalization, enabling SSRF in the right network shape. Archon pulls
axios transitively through @slack/bolt (^1.12.0) and @slack/web-api
(^1.13.5); before this change bun.lock resolved axios@1.13.6 — within
the vulnerable range.

Adding "axios": "^1.15.0" to the root package.json overrides bumps the
transitive resolution to axios@1.15.1 (latest compatible 1.x). Both
Slack range specs accept it without API surface changes — no downstream
code touches axios directly.

Supersedes #1153. Credits @stefans71 for identifying and reporting the
vulnerability; their PR was stale on the lockfile (0.3.5 → 0.3.6 drift
on dev), so this is a fresh one-line re-do on current dev.

Closes #1053.

Co-authored-by: Stefans71 <stefans71@users.noreply.github.com>
@Wirasm
Copy link
Copy Markdown
Collaborator

Wirasm commented Apr 27, 2026

@stefans71 this PR looks similar to the already-merged #1330 (merged 2026-04-22). The axios CVE-2025-62718 fix appears to have been landed in #1330 with credit to you (as noted in the comment above). Please check whether this PR is still needed — it is likely safe to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vulnerability in Archon project

2 participants