fix: override axios to ^1.15.0 for CVE-2025-62718#1153
fix: override axios to ^1.15.0 for CVE-2025-62718#1153stefans71 wants to merge 1 commit intocoleam00:devfrom
Conversation
Axios is a transitive dependency via @slack/bolt and @slack/web-api. The lockfile resolved to 1.13.6, which is vulnerable to NO_PROXY hostname normalization bypass (SSRF risk). Both Slack packages already accept ^1.15.0 via their semver ranges, so adding an override is sufficient. Closes coleam00#1053 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for catching this, @stefans71 — closing and re-opening on current `dev` with full credit to you. Your branch is 8 days behind `dev` and `bun.lock` conflicts on unrelated version bumps (0.3.5 → 0.3.6), so a one-line fix is cleaner re-done on a fresh branch than rebased. Crediting via `Co-authored-by:` on the replacement commit. Follow-up PR is inbound — will link it here. |
…1330) axios <1.15.0 can be coerced to bypass NO_PROXY rules via hostname normalization, enabling SSRF in the right network shape. Archon pulls axios transitively through @slack/bolt (^1.12.0) and @slack/web-api (^1.13.5); before this change bun.lock resolved axios@1.13.6 — within the vulnerable range. Adding "axios": "^1.15.0" to the root package.json overrides bumps the transitive resolution to axios@1.15.1 (latest compatible 1.x). Both Slack range specs accept it without API surface changes — no downstream code touches axios directly. Supersedes #1153. Credits @stefans71 for identifying and reporting the vulnerability; their PR was stale on the lockfile (0.3.5 → 0.3.6 drift on dev), so this is a fresh one-line re-do on current dev. Closes #1053. Co-authored-by: Stefans71 <stefans71@users.noreply.github.com>
|
@stefans71 this PR looks similar to the already-merged #1330 (merged 2026-04-22). The axios CVE-2025-62718 fix appears to have been landed in #1330 with credit to you (as noted in the comment above). Please check whether this PR is still needed — it is likely safe to close. |
Summary
"axios": "^1.15.0"tooverridesin rootpackage.jsonto fix CVE-2025-62718@slack/bolt(^1.12.0) and@slack/web-api(^1.13.5) — both already accept>=1.15.0via their semver rangesNO_PROXYrules via hostname normalization, potentially leading to SSRFCloses #1053
Test plan
bun installresolves axios to1.15.0in lockfilebun run type-checkpassesbun run validatepasses (CI)🤖 Generated with Claude Code
Summary by CodeRabbit