fix(core): add MiniMax M2 and auth env vars to subprocess allowlist

[hybridx]

Connection inventory:

From	To	Status	Notes
SUBPROCESS_ENV_ALLOWLIST	buildCleanSubprocessEnv()	unchanged	Function reads from set, no logic change
buildCleanSubprocessEnv()	claude.ts:buildSubprocessEnv()	unchanged	Caller unchanged
process.env	SUBPROCESS_ENV_ALLOWLIST	modified	9 new keys added to the set

Label Snapshot

• Risk: risk: low
• Size: size: XS
• Scope: core
• Module: core:env-allowlist

Change Metadata

• Change type: bug
• Primary scope: core

Linked Issue

• Closes Add MiniMax M2 API and additional environment variables to subprocess allowlist #1070

Validation Evidence (required)

bun run type-check   # ✅ all 9 packages pass
bun run lint         # ✅ 0 errors, 0 warnings
bun run format:check # ✅ all files pass

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Chores**
  * Extended subprocess environment variable configuration to support additional Anthropic authentication, model selection, and SDK tuning parameters.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

[coderabbitai]

📝 Walkthrough

Walkthrough

The change expands the SUBPROCESS_ENV_ALLOWLIST constant to include nine additional environment variables that support Anthropic API authentication, model configuration, and MiniMax M2 API tuning. These variables can now be forwarded to Claude Code subprocesses during execution.

Changes

Cohort / File(s)	Summary
Environment Allowlist Expansion packages/core/src/utils/env-allowlist.ts	Added 9 environment variables to SUBPROCESS_ENV_ALLOWLIST: ANTHROPIC_API_KEY, ANTHROPIC_AUTH_TOKEN, ANTHROPIC_MODEL, ANTHROPIC_SMALL_FAST_MODEL, ANTHROPIC_DEFAULT_SONNET_MODEL, ANTHROPIC_DEFAULT_OPUS_MODEL, ANTHROPIC_DEFAULT_HAIKU_MODEL, API_TIMEOUT_MS, and CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Twitches whiskers with glee

Ten new paths now open wide,
MiniMax credentials inside,
Anthropic models configured just right,
Claude Code subprocesses take flight! 🚀

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	Title mentions MiniMax M2 but the PR only adds Anthropic auth and config vars; MiniMax M2 variables are partially included but the title doesn't accurately reflect the full scope of authentication variables being added.	Clarify if this PR focuses on MiniMax M2 specifically or if it's primarily about adding auth/config vars; consider revising title to 'fix(core): add Anthropic auth and config env vars to subprocess allowlist' or similar.
Description check	❓ Inconclusive	PR description is missing key sections from the template including UX Journey, Architecture Diagram, Human Verification, Side Effects/Blast Radius, and Rollback Plan, though it does provide connection inventory, metadata, and validation evidence.	Add missing template sections: describe the UX impact (if any), provide architecture diagram showing module relationships, detail human verification steps performed, document potential side effects and rollback procedures.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR successfully addresses the primary objective of adding 9 environment variables to SUBPROCESS_ENV_ALLOWLIST to enable MiniMax M2 and auth-related functionality, with all required keys present.
Out of Scope Changes check	✅ Passed	The PR is narrowly scoped to env-allowlist.ts with no extraneous changes; the linked issue mentions a separate Settings UI update, which is correctly noted as out of scope for this PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/core/src/utils/env-allowlist.ts`:
- Around line 30-31: buildCleanSubprocessEnv now allows ANTHROPIC_API_KEY and
ANTHROPIC_AUTH_TOKEN but packages/core/src/clients/claude.ts only strips
CLAUDE_CODE_OAUTH_TOKEN and CLAUDE_API_KEY in the useGlobalAuth path, so
Anthropic credentials may be forwarded to subprocesses; update the useGlobalAuth
handling in claude.ts to also remove ANTHROPIC_API_KEY and ANTHROPIC_AUTH_TOKEN
from the subprocess environment (or explicitly throw a clear error if global
auth with Anthropic creds is unsupported) so the global-auth stripping behavior
stays consistent with buildCleanSubprocessEnv.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 99157d6c-7349-4343-adb7-96ece067d644

📥 Commits

Reviewing files that changed from the base of the PR and between 536584d and 39b2a18.

📒 Files selected for processing (1)

• packages/core/src/utils/env-allowlist.ts

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Global-auth token stripping is now incomplete for newly allowlisted Anthropic credentials.

After adding ANTHROPIC_API_KEY and ANTHROPIC_AUTH_TOKEN to the allowlist (Line 30 and Line 31), buildCleanSubprocessEnv() will forward them; however, packages/core/src/clients/claude.ts currently strips only CLAUDE_CODE_OAUTH_TOKEN and CLAUDE_API_KEY in useGlobalAuth mode. This can unintentionally pass Anthropic credentials into subprocesses when the code path expects auth tokens to be removed.

Suggested follow-up patch (outside this file)

- const { CLAUDE_CODE_OAUTH_TOKEN, CLAUDE_API_KEY, ...envWithoutAuth } = clean;
+ const {
+   CLAUDE_CODE_OAUTH_TOKEN,
+   CLAUDE_API_KEY,
+   ANTHROPIC_API_KEY,
+   ANTHROPIC_AUTH_TOKEN,
+   ...envWithoutAuth
+ } = clean;

  const filtered = [
    CLAUDE_CODE_OAUTH_TOKEN && 'CLAUDE_CODE_OAUTH_TOKEN',
    CLAUDE_API_KEY && 'CLAUDE_API_KEY',
+   ANTHROPIC_API_KEY && 'ANTHROPIC_API_KEY',
+   ANTHROPIC_AUTH_TOKEN && 'ANTHROPIC_AUTH_TOKEN',
  ].filter(Boolean);

As per coding guidelines, "Prefer throwing early with a clear error for unsupported/unsafe states - never silently swallow errors or broaden permissions (Fail Fast + Explicit Errors)".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/core/src/utils/env-allowlist.ts` around lines 30 - 31,
buildCleanSubprocessEnv now allows ANTHROPIC_API_KEY and ANTHROPIC_AUTH_TOKEN
but packages/core/src/clients/claude.ts only strips CLAUDE_CODE_OAUTH_TOKEN and
CLAUDE_API_KEY in the useGlobalAuth path, so Anthropic credentials may be
forwarded to subprocesses; update the useGlobalAuth handling in claude.ts to
also remove ANTHROPIC_API_KEY and ANTHROPIC_AUTH_TOKEN from the subprocess
environment (or explicitly throw a clear error if global auth with Anthropic
creds is unsupported) so the global-auth stripping behavior stays consistent
with buildCleanSubprocessEnv.

[Wirasm]

Addressed by the allowlist removal in #1092 — SUBPROCESS_ENV_ALLOWLIST has been deleted. All user-configured env vars (including ANTHROPIC_API_KEY, ANTHROPIC_AUTH_TOKEN, MiniMax model vars, etc.) now pass through to the subprocess automatically via process.env. Once #1092 merges, this PR can be closed.

[Wirasm]

Resolved by #1092 (allowlist removed — all MiniMax/auth vars pass through automatically).