Skip to content

fix(web): show env keys checkbox in add project dialog #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lraphael wants to merge 2 commits into from
+37 −45
Closed

fix(web): show env keys checkbox in add project dialog #1086

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b37539
fix(web): show env keys checkbox in add project dialog
Apr 11, 2026
7fce483
fix(web): remove duplicate env-keys checkbox from error state
Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 37 additions & 45 deletions packages/web/src/routes/SettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,15 +251,6 @@ function EnvVarsPanel({ codebaseId }: { codebaseId: string }): React.ReactElemen
);
}

function isEnvLeakError(error: unknown): boolean {
return (
error instanceof Error &&
'status' in error &&
(error as Error & { status: number }).status === 422 &&
error.message.startsWith('Cannot add codebase')
);
}

function ProjectsSection(): React.ReactElement {
const queryClient = useQueryClient();
const [addPath, setAddPath] = useState('');
Expand Down Expand Up @@ -394,30 +385,43 @@ function ProjectsSection(): React.ReactElement {
)}

{showAdd ? (
<form onSubmit={handleAddSubmit} className="mt-3 flex gap-2">
<Input
value={addPath}
onChange={e => {
setAddPath(e.target.value);
}}
placeholder="/path/to/repository"
className="flex-1"
/>
<Button type="submit" size="sm" disabled={addMutation.isPending}>
Add
</Button>
<Button
type="button"
variant="ghost"
size="sm"
onClick={() => {
setShowAdd(false);
setAddPath('');
}}
>
Cancel
</Button>
</form>
<div className="mt-3 space-y-2">
<form onSubmit={handleAddSubmit} className="flex gap-2">
<Input
value={addPath}
onChange={e => {
setAddPath(e.target.value);
}}
placeholder="/path/to/repository"
className="flex-1"
/>
<Button type="submit" size="sm" disabled={addMutation.isPending}>
Add
</Button>
<Button
type="button"
variant="ghost"
size="sm"
onClick={() => {
setShowAdd(false);
setAddPath('');
setAllowEnvKeys(false);
}}
>
Cancel
</Button>
</form>
<label className="flex items-center gap-2 text-sm text-text-secondary">
<input
type="checkbox"
checked={allowEnvKeys}
onChange={e => {
setAllowEnvKeys(e.target.checked);
}}
/>
Allow env keys (I understand the risk)
</label>
</div>
Comment thread
coderabbitai[bot] marked this conversation as resolved.
) : (
<Button
variant="outline"
Expand All @@ -436,18 +440,6 @@ function ProjectsSection(): React.ReactElement {
{addMutation.error instanceof Error
? addMutation.error.message
: 'Failed to add project'}
{isEnvLeakError(addMutation.error) && (
<label className="mt-2 flex items-center gap-2 text-text-secondary">
<input
type="checkbox"
checked={allowEnvKeys}
onChange={e => {
setAllowEnvKeys(e.target.checked);
}}
/>
Allow env keys (I understand the risk)
</label>
)}
</div>
)}
</CardContent>
Expand Down