-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(cli): send workflow dispatch/result messages for Web UI cards #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+296
−23
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6919351
fix(cli): send workflow dispatch/result messages for Web UI cards (#1…
coleam00 7cae3a1
fix(cli): guard dispatch sendMessage, improve comments and add tests …
coleam00 25757b8
simplify: remove redundant String() wrapping in template literals
coleam00 b8e367f
simplify: reduce complexity in changed files
coleam00 5685b41
fix(cli): add cli. domain prefix to log event names
coleam00 b620c04
fix(web): add defensive optional chaining for workflow run data access
coleam00 51b8652
fix: complete defensive chaining and add missing test coverage for PR…
coleam00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 80
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 1988
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 41
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 41
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 4585
🏁 Script executed:
# Look at the top of the test file to see how mocking is set up head -100 packages/cli/src/commands/workflow.test.tsRepository: coleam00/Archon
Length of output: 3235
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 746
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 371
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 503
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 441
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 208
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 6924
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 2506
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 354
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 2780
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 3524
🏁 Script executed:
Repository: coleam00/Archon
Length of output: 1279
Use
mockImplementationOnce()to prevent test isolation violations.The
mockImplementation()calls at lines 998–1008 persist beyond this test case. SincemockClear()in subsequent tests only clears call history but preserves the implementation, later tests inherit these persistent behaviors and become order-dependent. Replace both withmockImplementationOnce()to ensure each mock applies only to the next call.Suggested change
📝 Committable suggestion
🤖 Prompt for AI Agents