feat: add archon serve command for one-command web UI install
#1011
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| import { describe, it, expect, mock, beforeEach, afterEach, spyOn } from 'bun:test'; | ||
|
|
||
| // Mock @archon/paths BEFORE importing the module under test. | ||
| // This sets BUNDLED_IS_BINARY = false (dev mode) so serveCommand rejects. | ||
| const mockLogger = { | ||
| fatal: mock(() => undefined), | ||
| error: mock(() => undefined), | ||
| warn: mock(() => undefined), | ||
| info: mock(() => undefined), | ||
| debug: mock(() => undefined), | ||
| trace: mock(() => undefined), | ||
| }; | ||
| mock.module('@archon/paths', () => ({ | ||
| createLogger: mock(() => mockLogger), | ||
| getWebDistDir: mock((version: string) => `/tmp/test-archon/web-dist/${version}`), | ||
| BUNDLED_IS_BINARY: false, | ||
| BUNDLED_VERSION: 'dev', | ||
| })); | ||
|
|
||
| import { serveCommand, parseChecksum } from './serve'; | ||
|
|
||
| describe('parseChecksum', () => { | ||
| const validHash = 'a'.repeat(64); | ||
|
|
||
| it('should extract hash for matching filename', () => { | ||
| const checksums = [ | ||
| `${'b'.repeat(64)} archon-linux-x64`, | ||
| `${validHash} archon-web.tar.gz`, | ||
| `${'c'.repeat(64)} archon-darwin-arm64`, | ||
| ].join('\n'); | ||
|
|
||
| expect(parseChecksum(checksums, 'archon-web.tar.gz')).toBe(validHash); | ||
| }); | ||
|
|
||
| it('should handle single-space separator', () => { | ||
| const checksums = `${validHash} archon-web.tar.gz\n`; | ||
| expect(parseChecksum(checksums, 'archon-web.tar.gz')).toBe(validHash); | ||
| }); | ||
|
|
||
| it('should throw for missing filename', () => { | ||
| const checksums = `${validHash} archon-linux-x64\n`; | ||
| expect(() => parseChecksum(checksums, 'archon-web.tar.gz')).toThrow( | ||
| 'Checksum not found for archon-web.tar.gz' | ||
| ); | ||
| }); | ||
|
|
||
| it('should throw for empty checksums text', () => { | ||
| expect(() => parseChecksum('', 'archon-web.tar.gz')).toThrow('Checksum not found'); | ||
| }); | ||
|
|
||
| it('should skip blank lines', () => { | ||
| const checksums = `\n${validHash} archon-web.tar.gz\n\n`; | ||
| expect(parseChecksum(checksums, 'archon-web.tar.gz')).toBe(validHash); | ||
| }); | ||
|
|
||
| it('should throw for malformed hash (not 64 hex chars)', () => { | ||
| const checksums = 'short_hash archon-web.tar.gz\n'; | ||
| expect(() => parseChecksum(checksums, 'archon-web.tar.gz')).toThrow( | ||
| 'Malformed checksum entry for archon-web.tar.gz' | ||
| ); | ||
| }); | ||
|
|
||
| it('should throw for uppercase hex hash', () => { | ||
| const checksums = `${'A'.repeat(64)} archon-web.tar.gz\n`; | ||
| expect(() => parseChecksum(checksums, 'archon-web.tar.gz')).toThrow( | ||
| 'Malformed checksum entry for archon-web.tar.gz' | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| describe('serveCommand', () => { | ||
| let consoleErrorSpy: ReturnType<typeof spyOn>; | ||
|
|
||
| beforeEach(() => { | ||
| consoleErrorSpy = spyOn(console, 'error').mockImplementation(() => {}); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| consoleErrorSpy.mockRestore(); | ||
| }); | ||
|
|
||
| it('should reject in dev mode (non-binary)', async () => { | ||
| const exitCode = await serveCommand({}); | ||
| expect(exitCode).toBe(1); | ||
| expect(consoleErrorSpy).toHaveBeenCalledWith( | ||
| 'Error: `archon serve` is for compiled binaries only.' | ||
| ); | ||
| }); | ||
|
|
||
| it('should reject with downloadOnly in dev mode', async () => { | ||
| const exitCode = await serveCommand({ downloadOnly: true }); | ||
| expect(exitCode).toBe(1); | ||
| }); | ||
|
|
||
| it('should reject invalid port (NaN)', async () => { | ||
| const exitCode = await serveCommand({ port: NaN }); | ||
| expect(exitCode).toBe(1); | ||
| expect(consoleErrorSpy).toHaveBeenCalledWith( | ||
| expect.stringContaining('--port must be an integer between 1 and 65535') | ||
| ); | ||
| }); | ||
|
|
||
| it('should reject port out of range', async () => { | ||
| const exitCode = await serveCommand({ port: 99999 }); | ||
| expect(exitCode).toBe(1); | ||
| expect(consoleErrorSpy).toHaveBeenCalledWith( | ||
| expect.stringContaining('--port must be an integer between 1 and 65535') | ||
| ); | ||
| }); | ||
|
|
||
| it('should reject port 0', async () => { | ||
| const exitCode = await serveCommand({ port: 0 }); | ||
| expect(exitCode).toBe(1); | ||
| expect(consoleErrorSpy).toHaveBeenCalledWith( | ||
| expect.stringContaining('--port must be an integer between 1 and 65535') | ||
| ); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate checksum entry for
archon-web.tar.gz.The glob
archon-*already matchesarchon-web.tar.gz(since it starts with "archon-"), so explicitly adding it results in a duplicate line inchecksums.txt. This could cause issues with checksum verification if the parser doesn't handle duplicates gracefully.🔧 Proposed fix
- name: Generate checksums run: | cd dist - sha256sum archon-* archon-web.tar.gz > checksums.txt + sha256sum archon-* > checksums.txt cat checksums.txt🤖 Prompt for AI Agents