fix(utils): correct misleading port-range comment in calculatePortOffset#1009
Conversation
The inline comment stated ports 3100-3999 (implying basePort=3000) but the actual basePort is 3090, making the true range 3190-4089, which already matched the JSDoc. Update the inline comment to agree with both the JSDoc and the arithmetic. Closes coleam00#1008
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change corrects a misleading inline comment in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…feat-claude-sdk-node-options feat(workflows): expose Claude SDK node options per DAG node
…feat-claude-sdk-node-options feat(workflows): expose Claude SDK node options per DAG node
…set (coleam00#1009) The inline comment stated ports 3100-3999 (implying basePort=3000) but the actual basePort is 3090, making the true range 3190-4089, which already matched the JSDoc. Update the inline comment to agree with both the JSDoc and the arithmetic. Closes coleam00#1008
…feat-claude-sdk-node-options feat(workflows): expose Claude SDK node options per DAG node
…set (coleam00#1009) The inline comment stated ports 3100-3999 (implying basePort=3000) but the actual basePort is 3090, making the true range 3190-4089, which already matched the JSDoc. Update the inline comment to agree with both the JSDoc and the arithmetic. Closes coleam00#1008
Closes #1008
Problem
The inline comment in
calculatePortOffsetsays ports will be in3100-3999range, but withbasePort = 3090the actual range is3190-4089. This contradicts the comment and confuses developers reading the code.Fix
Updated the inline comment to correctly state
3190-4089range. The JSDoc above the function was already accurate.Summary by CodeRabbit