Skip to content

use improved Python package identification #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dirk-thomas wants to merge 1 commit into from
Closed

use improved Python package identification #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions colcon_ros/package_identification/ros.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from colcon_core.plugin_system import satisfies_version
from colcon_core.plugin_system import SkipExtensionException
from colcon_python_setup_py.package_identification.python_setup_py \
import get_setup_arguments_with_context
import get_setup_information


# mapping paths to tuples containing the ROS package and its build type
Expand Down Expand Up @@ -124,8 +124,8 @@ def getter(env):

def getter(env): # noqa: F811
nonlocal desc
return get_setup_arguments_with_context(
str(desc.path / 'setup.py'), env)
return get_setup_information(
desc.path / 'setup.py', env=env)

desc.metadata['get_python_setup_options'] = getter

Expand Down