Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for committer status #21

Closed
mxgrey opened this issue Jul 22, 2024 · 4 comments
Closed

Request for committer status #21

mxgrey opened this issue Jul 22, 2024 · 4 comments

Comments

@mxgrey
Copy link

mxgrey commented Jul 22, 2024

@nuclearsandwich Similar to colcon/colcon-cargo#31 this repo currently suffers from an absence of active maintainers.

There's a much anticipated PR #19 that is a crucial prerequisite for getting this colcon extension released on packagecloud, but it's currently blocked by the absence of reviews by anyone with committer status.

I'd like to request committer status for myself and @luca-della-vedova on the same rationale as the request for colcon-cargo since the two are strongly related and even interlinked.

@esteve
Copy link
Collaborator

esteve commented Aug 19, 2024

@mxgrey thanks for the offer, I've added @luca-della-vedova as a maintainer since he's the one who's been contributing to the project

@esteve esteve closed this as completed Aug 19, 2024
@mxgrey
Copy link
Author

mxgrey commented Aug 19, 2024

Thanks @esteve , then I'll look forward to Luca's PR getting reviewed by an existing maintainer since he can't approve his own for the merge requirements to be met.

@esteve
Copy link
Collaborator

esteve commented Aug 19, 2024

@mxgrey I just merged #19 , for some reason I thought @maspe36 and @jhdcs were already maintainers of this repo, so I didn't check #19 and assumed it got merged a while ago.

@mxgrey
Copy link
Author

mxgrey commented Aug 19, 2024

Thanks, I believe the release onto packagecloud is also blocked on #22 which is blocked on colcon/colcon-cargo#39 .

Fortunately colcon/colcon-cargo#39 does have at least one approval from a maintainer (Steven!). Later this week I'll do a review of that one myself and approve+merge if everything seems reasonable since I have maintainer status on colcon-cargo. But after that #22 will be waiting for a colcon-ros-cargo maintainer for approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants