Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around changes to argparse private API #673

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Oct 15, 2024

Unfortunately, achieving colcon's arbitrary argument parsing involves reaching into argparse private API. There was recently a change to that API which was backported to stable Python releases, and this change is necessary to restore the desired behavior.

Unfortunately, achieving colcon's arbitrary argument parsing involves
reaching into argparse private API. There was recently a change to that
API which was backported to stable Python releases, and this change is
necessary to restore the desired behavior.
@cottsay cottsay added the bug Something isn't working label Oct 15, 2024
@cottsay cottsay added this to the 0.18.2 milestone Oct 15, 2024
@cottsay cottsay self-assigned this Oct 15, 2024
@cottsay
Copy link
Member Author

cottsay commented Oct 15, 2024

CI is still broken due to colcon/ci#34, which could also use a review.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm completely fine with this as a change to unbreak colcon, so approving.

But at this point, it might be worth considering contributing to upstream argparse to add in some kind of functionality so we are using a "stable" API.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.37%. Comparing base (faee881) to head (b3154c3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
+ Coverage   87.32%   87.37%   +0.05%     
==========================================
  Files          68       68              
  Lines        3945     3945              
  Branches      777      756      -21     
==========================================
+ Hits         3445     3447       +2     
  Misses        396      396              
+ Partials      104      102       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cottsay cottsay merged commit ed3ffb5 into master Oct 16, 2024
41 of 46 checks passed
@cottsay cottsay deleted the cottsay/another-argparse-regression branch October 16, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants