Skip to content

Revert "print python coverage results to console"#333

Merged
dirk-thomas merged 1 commit intomasterfrom
revert-331-pytest-cov-console
Apr 1, 2020
Merged

Revert "print python coverage results to console"#333
dirk-thomas merged 1 commit intomasterfrom
revert-331-pytest-cov-console

Conversation

@dirk-thomas
Copy link
Member

Reverts #331 - see #331 (comment).

@dirk-thomas
Copy link
Member Author

For convenience I readded the value to the mixin: colcon/colcon-mixin-repository#22 (as originally proposed).

@dirk-thomas
Copy link
Member Author

@mikaelarguedas FYI.

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@52f3893). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #333   +/-   ##
=========================================
  Coverage          ?   79.75%           
=========================================
  Files             ?       55           
  Lines             ?     3226           
  Branches          ?      537           
=========================================
  Hits              ?     2573           
  Misses            ?      608           
  Partials          ?       45           
Impacted Files Coverage Δ
colcon_core/task/python/test/pytest.py 0.00% <ø> (ø)
colcon_core/shell/bat.py 90.47% <0.00%> (ø)
colcon_core/event/job.py 96.29% <0.00%> (ø)
colcon_core/prefix_path/colcon.py 90.47% <0.00%> (ø)
colcon_core/shell/__init__.py 98.42% <0.00%> (ø)
colcon_core/logging.py 93.10% <0.00%> (ø)
colcon_core/environment/__init__.py 100.00% <0.00%> (ø)
colcon_core/verb/test.py 28.15% <0.00%> (ø)
colcon_core/argument_default.py 100.00% <0.00%> (ø)
colcon_core/__init__.py 100.00% <0.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f3893...8a80acd. Read the comment docs.

Copy link
Contributor

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dirk-thomas dirk-thomas merged commit 3fc4829 into master Apr 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the revert-331-pytest-cov-console branch April 1, 2020 15:22
@dirk-thomas dirk-thomas added this to the 0.5.6 milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants