Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of pages to 10 (1000 coins) to reduce the load on backend... #255

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

lyricnz
Copy link
Collaborator

@lyricnz lyricnz commented Oct 25, 2021

...and increase refresh time. This will also stop coingecko blocking people for >50 requests/minute. See #104 #228

@miguelmota
Copy link
Member

LGTM! I think in the future we can have optional max_pages and per_page settings in the config file

@lyricnz
Copy link
Collaborator Author

lyricnz commented Oct 28, 2021

I had a quick attempt to add this config, but got lost in the maze of ct.State vs ct.Config vs multiple entry points :/

@lyricnz lyricnz merged commit ac946a7 into cointop-sh:master Oct 28, 2021
@lyricnz lyricnz deleted the feature/reduce-coin-count branch October 28, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants