Skip to content

fix: Add baseBuilder.allowedAddresses to template + call setFrameReady() automatically #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2025
Merged

fix: Add baseBuilder.allowedAddresses to template + call setFrameReady() automatically #2503

merged 3 commits into from
Sep 22, 2025

Conversation

dgca
Copy link
Contributor

@dgca dgca commented Sep 22, 2025

What changed? Why?

  • Adds baseBuilder.allowedAddresses to minikit template
  • Calls setFrameReady() in minikit template (user can override this)

Notes to reviewers

How has it been tested?

@cb-heimdall
Copy link

cb-heimdall commented Sep 22, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel Vercel
Copy link

vercel bot commented Sep 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ock-minikit-example Ready Ready Preview Comment Sep 22, 2025 9:28pm
onchainkit-playground Ready Ready Preview Comment Sep 22, 2025 9:28pm
onchainkit-routes Ready Ready Preview Comment Sep 22, 2025 9:28pm

xtbase
xtbase previously approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@xtbase xtbase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's also change frame to miniapp can be in a follow up if needed

@dgca dgca merged commit dc780b1 into main Sep 22, 2025
15 checks passed
@dgca dgca deleted the danc/base-builder-allowed-addresses-in-minikit-template branch September 22, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xtbase xtbase xtbase approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgca @cb-heimdall @xtbase