Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove WalletConnect reference #1765

Merged
merged 2 commits into from
Dec 18, 2024
Merged

docs: Remove WalletConnect reference #1765

merged 2 commits into from
Dec 18, 2024

Conversation

cpcramer
Copy link
Contributor

@cpcramer cpcramer commented Dec 18, 2024

What changed? Why?
WalletConnect has been deprecated.

Notes to reviewers

How has it been tested?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 18, 2024
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 5:37pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 5:37pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 5:37pm

@@ -31,8 +31,6 @@ Play with it live [here](https://onchain-app-template.vercel.app).

## Getting Started

::::steps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was rendering incorrectly:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-18 at 9 28 39 AM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's odd, it should correspond with :::: at line 92, shows correctly currently https://onchainkit.xyz/guides/build-onchain-apps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, that's weird. I'll leave it in then.

@cpcramer cpcramer requested a review from alessey December 18, 2024 17:28
@cpcramer cpcramer merged commit eb08890 into main Dec 18, 2024
16 checks passed
@dschlabach dschlabach deleted the paul/docs-remove-old branch December 18, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

3 participants