headerLeftContent in Swap #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alessey
reviewed
Dec 17, 2024
|
Thank you! |
alessey
approved these changes
Dec 17, 2024
cpcramer
reviewed
Dec 17, 2024
| @@ -298,7 +298,8 @@ export type SwapReact = { | |||
| onError?: (error: SwapError) => void; // An optional callback function that handles errors within the provider. | |||
| onStatus?: (lifecycleStatus: LifecycleStatus) => void; // An optional callback function that exposes the component lifecycle state | |||
| onSuccess?: (transactionReceipt: TransactionReceipt) => void; // An optional callback function that exposes the transaction receipt | |||
| title?: string; // Title for the Swap component. (default: "Swap") | |||
| title?: ReactNode; // Title for the Swap component. (default: "Swap") | |||
| headerLeftContent?: ReactNode; // Header left content for the Swap component (eg. back button). | |||
There was a problem hiding this comment.
Why not just call this the backButton? Or make it into a back button sub component?
There was a problem hiding this comment.
what other elements are we expecting to be passed through here?
There was a problem hiding this comment.
that was the original change, but we made it more generic to be able to handle things like logos, tray-open/close-buttons, etc.
cpcramer
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?
locally, in playground