docs: fix minor grammar issues #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@mdqst is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
alessey
reviewed
Dec 17, 2024
site/docs/pages/fund/types.mdx
Outdated
| @@ -41,7 +41,7 @@ type GetOnrampUrlWithProjectIdParams = { | |||
| projectId: string; | |||
| sessionToken?: never; // You cannot provide sessionToken when using projectId | |||
| /** | |||
| * The addresses that the customer's funds should be delivered to. | |||
| * The address that the customer's funds should be delivered to. | |||
There was a problem hiding this comment.
can be multiple addresses on different networks
dschlabach
reviewed
Dec 17, 2024
dschlabach
approved these changes
Dec 17, 2024
dschlabach
changed the title
cpcramer
approved these changes
Dec 17, 2024
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
I made some small corrections to the documentation to improve clarity and accuracy:
The phrase "A optional prop" was changed to "An optional prop" to follow the correct usage of the article. Since "optional" starts with a vowel sound, it should be preceded by "an" instead of "a."
The phrase "The addresses that the customer's funds should be delivered to" was adjusted to "The address that the customer's funds should be delivered to" to reflect proper grammar. Although multiple addresses might be implied, it's more grammatically appropriate to use the singular "address" in this context.
Notes to reviewers
These changes should help ensure that the documentation is more grammatically correct and easier to understand.