Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Fund Card component #1718

Merged
merged 106 commits into from
Jan 16, 2025
Merged

Implement Fund Card component #1718

merged 106 commits into from
Jan 16, 2025

Conversation

rustam-cb
Copy link
Contributor

@rustam-cb rustam-cb commented Dec 11, 2024 •
edited
Loading

What changed? Why?
Implemented a new component FundCard
P/PS: https://docs.google.com/document/d/1y57fxsga2ZLF8-ieH2OY7jvqx5468txQuek1WTYPBxE/edit?tab=t.0

Usage:

FundCard assetSymbol="ETH" />

Component is customizable and there are few components that can be passed into it.

  AmountInputComponent 
  HeaderComponent
  AmountInputTypeSwithComponent
  PaymentMethodSelectorDropdownComponent
  SubmitButtonComponent
Fiat input Crypto input
Screenshot 2024-12-17 at 9 38 52 PM Screenshot 2024-12-17 at 9 39 06 PM
No input (default) payment method dropdown
Screenshot 2024-12-17 at 9 38 41 PM Screenshot 2024-12-17 at 9 39 20 PM

Notes to reviewers
Overall component structure:

  • FundCard
    • HeaderComponent
    • AmountInputComponent
    • PaymentMethodDropdownComponent
    • SubmitButtonComponent

How has it been tested?

  • Unit tests
  • Manual testing

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 7:57pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 7:57pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 7:57pm

@rustam-cb rustam-cb requested a review from alessey January 16, 2025 18:13
alessey
alessey previously approved these changes Jan 16, 2025
View reviewed changes
abcrane123
abcrane123 previously approved these changes Jan 16, 2025
View reviewed changes
@rustam-cb rustam-cb dismissed stale reviews from abcrane123 and alessey via f785493 January 16, 2025 19:52
@rustam-cb rustam-cb merged commit 2f65eb9 into main Jan 16, 2025
16 checks passed
@rustam-cb rustam-cb deleted the fund-form branch January 16, 2025 20:03
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendan-defi brendan-defi brendan-defi approved these changes

@alessey alessey alessey approved these changes

@dschlabach dschlabach Awaiting requested review from dschlabach

@cpcramer cpcramer Awaiting requested review from cpcramer

@abcrane123 abcrane123 Awaiting requested review from abcrane123

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation pkg: fund pkg: styles pkg: swap root
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rustam-cb @cpcramer @alessey @mindapivessa @abcrane123 @dschlabach @brendan-defi