Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved funding flow in Checkout #1692

Merged
merged 4 commits into from
Dec 9, 2024
Merged

feat: improved funding flow in Checkout #1692

merged 4 commits into from
Dec 9, 2024

Conversation

0xAlec
Copy link
Contributor

@0xAlec 0xAlec commented Dec 3, 2024

What changed? Why?

  • do not render Get USDC if insufficient funds
  • instead, have original initial click bring user to keys.coinbase.com/fund
  • open funding link in popup instead of new tab

Notes to reviewers

How has it been tested?
unit tests and playground

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 5:41pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 5:41pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 5:41pm

@0xAlec 0xAlec merged commit da7491a into main Dec 9, 2024
16 checks passed
@0xAlec 0xAlec deleted the alec/fund branch December 9, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants