Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add
onConnect
handler to<ConnectWallet />
#1529New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add
onConnect
handler to<ConnectWallet />
#1529Changes from 30 commits
5e172e7
8087864
1ba10f2
482acb2
f6622fb
7ddd0fe
6ee2629
e84bff3
a3f3cf2
0dddd5e
f6514e2
1deb207
8830380
87dc933
db75d31
07fc53d
2c7fbea
ba687b1
1d01215
78ca04d
84c221e
a1c6eca
a7eb783
169682c
a44e5a9
be2ebba
140ac2d
3c4cc2c
3549d07
11497f4
05b585b
d0720f6
69227f8
c1890e8
b0a4c98
af8c06d
492d0ea
c45afcb
cfadac0
bdb8b0f
06dd7b4
3686242
330831a
1f87f10
6440e1e
3f073a3
209e63a
9969089
8d7cdac
2b84a2e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we'd be able to avoid this piece of state, but there's no other way to detect whether
status === 'connected'
is true because:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safer, more reliable way of triggering the callback. We have to use the useEffect and state for RainbowKit support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: let's keep this comment inline with
onInitialConnect
, similar to the other comments in this fileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, updated.
BTW the reason for using multiline comments is that the comment then shows up in Intellisense. I think this helps improve DX (internally and externally) but I understand that we already have a convention around
//
style comments.