-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add browser window check in usePreferredColorScheme #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
changed the title
Add window check for server side errors
chore: Add browser window check in usePreferredColoScheme
Oct 16, 2024
cpcramer
force-pushed
the
paul/window-check
branch
from
October 16, 2024 18:31
5e8175b
to
4d6fe9d
Compare
0xAlec
reviewed
Oct 16, 2024
cpcramer
force-pushed
the
paul/window-check
branch
from
October 16, 2024 18:45
c5abfc3
to
df579a1
Compare
0xAlec
approved these changes
Oct 16, 2024
cpcramer
changed the title
chore: Add browser window check in usePreferredColoScheme
chore: Add browser window check in usePreferredColorScheme
Oct 16, 2024
alessey
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Add browser window check to avoid server side errors when the browser window does not exist.
Notes to reviewers
How has it been tested?