-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nft api #1409
nft api #1409
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4e93e9a
to
8d663fd
Compare
8d663fd
to
7b9d0a0
Compare
7b9d0a0
to
8d58dc7
Compare
8d58dc7
to
8670211
Compare
8670211
to
028d701
Compare
028d701
to
127d13d
Compare
127d13d
to
f309bb7
Compare
)} | ||
data-testid="ockNFTMintCardFallback_Container" | ||
> | ||
<div>Sorry, we had an unhandled error</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, this copy should be Sorry, please try again later.
to be consistent with our other 500 responses
@@ -18,19 +18,19 @@ export function NFTAssetCost({ className }: NFTAssetCostReact) { | |||
return null; | |||
} | |||
|
|||
if (price?.amount === 0) { | |||
if (Number(price?.amount) === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amount
is in wei right? you'll get an overflow casting this to Number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should use native BigInt here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, its in ETH, converted on the BE
What changed? Why?
Add api functions to interact with new rpc_proxy methods from https://github.cbhq.net/cloud/rpc-proxy/pull/488
Notes to reviewers
How has it been tested?