Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nft api #1409

Merged
merged 18 commits into from
Nov 1, 2024
Merged

nft api #1409

merged 18 commits into from
Nov 1, 2024

Conversation

alessey
Copy link
Contributor

@alessey alessey commented Oct 14, 2024

What changed? Why?
Add api functions to interact with new rpc_proxy methods from https://github.cbhq.net/cloud/rpc-proxy/pull/488

  • GetTokenDetails
  • GetMintDetails
  • MintToken

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 8:26pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 8:26pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 8:26pm

)}
data-testid="ockNFTMintCardFallback_Container"
>
<div>Sorry, we had an unhandled error</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, this copy should be Sorry, please try again later. to be consistent with our other 500 responses

@@ -18,19 +18,19 @@ export function NFTAssetCost({ className }: NFTAssetCostReact) {
return null;
}

if (price?.amount === 0) {
if (Number(price?.amount) === 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amount is in wei right? you'll get an overflow casting this to Number

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use native BigInt here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, its in ETH, converted on the BE

src/nft/utils/ipfs.ts Outdated Show resolved Hide resolved
@alessey alessey merged commit 24ade63 into main Nov 1, 2024
16 checks passed
@alessey alessey deleted the alessey/nft-data branch November 1, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants