feat: keep polishing onStatus lifecycle #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Zizzamia
force-pushed
the
zizzamia/potato-8-14
branch
from
5709017 to
b19e7d3
Compare
Zizzamia
commented
Aug 15, 2024
| @@ -252,30 +259,6 @@ describe('TransactionProvider', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should call onSuccess when receipts are available', async () => { | |||
There was a problem hiding this comment.
Apperently this test was not testing what was suppose to test 🤦🏻♂️
Zizzamia
commented
Aug 15, 2024
| @@ -382,34 +365,6 @@ describe('TransactionProvider', () => { | |||
| ); | |||
| }); | |||
| }); | |||
|
|
|||
| it('should call onSuccess when receiptArray has receipts', async () => { | |||
There was a problem hiding this comment.
Same for this one. I am rewriting the entire logic in a more simple way so we can actually test this.
Zizzamia
force-pushed
the
zizzamia/potato-8-14
branch
from
d428ee1 to
8532b4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?