Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add customized info in sdk's fetcher, reconciler, syncer and db #465

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

jingweicb
Copy link
Contributor

@jingweicb jingweicb commented Jan 13, 2023

Fixes # .

Aim to enable customized logs in sdk

why added in fetcher, reconciler, syncer and db instead of other packages?
because they are the most frequent used packages for cli

will add to other packages?
yes, but the priority is not as high as fetcher, reconciler, syncer and db

notifications:
make changes are related to check-gen and go lint, for the first commit contains most important content
for the meteData in struct, it will be "", or some string begin with", "

Screenshot 2023-01-13 at 1 43 41 PM

Motivation

Solution

Open questions

@jingweicb jingweicb merged commit 4c69164 into master Jan 13, 2023
@jingweicb jingweicb deleted the jingwei/add-customized-info branch January 13, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants