Remove pandas-gbq from extras and fix typo #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaul
approved these changes
May 10, 2023
Contributor
bnaul
left a comment
bnaul
left a comment
There was a problem hiding this comment.
github actions is having issues, maybe try once more but I wouldn't block on every single build succeeding since nothing here seems platform-dependent
Contributor
Author
|
Yes just saw that. I'll wait for a bit but if it doesn't finish I'd say we merge anyways, I'd like to get the release #51 in today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some cleanup for the release, I noticed that we have an extra dependency in
setup.pythat is no longer needed, see this PR #31 . I double-check with @j-bennet and @bnaul and removing it is the right move.This PR removes the dependency and fixes a typo