Use PlatformContext's companion object instead of PlatformContext.INSTANCE #2814
+15
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Use
PlatformContext
'scompanion object
instead ofPlatformContext.INSTANCE
.This code style exists in the official Kotlin library, such as
kotlin.io.encoding.Base64
andkotlinx.serialization.json.Json
classes.One object is reduced, which can theoretically improve performance slightly.
This brings API changes. In some cases, the compiler may infer the
PlatformContext.Companion
type instead ofPlatformContext
.Please run
./test.sh
before submitting to ensure your pull request passes the automated checks.gradlew apiCheck spotlessCheck
gradlew allTests testDebugUnitTest connectedDebugAndroidTest validateDebugScreenshotTest verifyPaparazziDebug verifyRoborazziDebug verifyRoborazziJvm
I only have Windows devices. When I run the test, I get a lot of errors related to
filePath
.After checking, there are no errors related to this change.