Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies are stale #2

Closed
jaraco opened this issue May 24, 2024 · 2 comments
Closed

Dependencies are stale #2

jaraco opened this issue May 24, 2024 · 2 comments
Assignees

Comments

@jaraco
Copy link
Member

jaraco commented May 24, 2024

In an attempt to re-use unchanged dependencies, the test runner invokes the persistent strategy:

PIP_RUN_RETENTION_STRATEGY='persist',

Unfortunately, the way that strategy is implemented, it keys the environment on the requirements, which are always .[test] (even across projects), meaning that from run to run, the same environment is used even if the dependencies (or project under test) have changed, leading to ImportErrors when those dependencies are used.

Probably, the pip-run persistent strategy should resolve the dependencies and then key on the solved dependency tree... or at least key on the resolution of the indicated dependencies (i.e. expand requirements.txt and dependencies implied by local paths).

jaraco added a commit that referenced this issue May 24, 2024
@jaraco jaraco self-assigned this Jun 6, 2024
@jaraco
Copy link
Member Author

jaraco commented Jun 6, 2024

Disabling the persistent strategy works around the issue, so it can be closed. We'll want to track a more permanent solution and re-enable re-used environments, but that's something that can wait.

@jaraco
Copy link
Member Author

jaraco commented Jun 19, 2024

I noticed you re-opened this issue. I wasn't really sure why. Now I realize it was I mistakenly pointed to this issue instead of another. Glad to see you making some progress on a more permanent solution!

@jaraco jaraco closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants