Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coral-web: move update agent info banner above form on mobile #288

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

misspia-cohere
Copy link
Contributor

@misspia-cohere misspia-cohere commented Jun 25, 2024

Save some vertical space on mobile and still ensure the user sees the info banner when the update panel is opened

Before

Screen.Recording.2024-06-25.at.15.15.56.mov

After

Screen.Recording.2024-06-25.at.15.34.01.mov

AI Description

This pull request makes changes to the UpdateAgentPanel component in the src/interfaces/coral_web/src/components/Agents/UpdateAgentPanel.tsx file.

Summary

The UpdateAgentPanel component now includes an InfoBanner displaying a message that updating the agent will impact all assistant users. This message was previously displayed using a Banner component.

Changes

  • Adds an InfoBanner component to display the message about the impact of agent updates.
  • Updates the styling of the InfoBanner component using the className prop.
  • Moves the message about the impact of agent updates from the Banner to the InfoBanner component.
  • Adjusts the padding and margin values for the div containing the InfoBanner and Button components.

Copy link
Contributor

@wujessica wujessica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also make the x-padding less thick for mobile haha

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@26f19e8). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage        ?   85.27%           
=======================================
  Files           ?      161           
  Lines           ?     5928           
  Branches        ?        0           
=======================================
  Hits            ?     5055           
  Misses          ?      873           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@misspia-cohere misspia-cohere merged commit 7b26fc2 into main Jun 25, 2024
2 checks passed
@misspia-cohere misspia-cohere deleted the pia/update-agent-form-footer branch June 25, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants