Skip to content

coral-web: add missing 'as' prop to transition component #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

misspia-cohere
Copy link
Contributor

@misspia-cohere misspia-cohere commented Jun 14, 2024

Thank you for contributing to the Cohere Toolkit!

  • PR title: "area: description"

    • Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
    • Example: "deployment: add Azure model option"
  • PR message: Delete this entire checklist and replace with

    • Description: a description of the change
    • Issue: the issue # it fixes, if applicable
    • Dependencies: any dependencies required for this change
  • Add tests and docs: Please include testing and documentation for your changes

  • Lint and test: Run make lint and make run-tests

AI Description

This pull request makes changes to the MessageContent component in the src/interfaces/coral_web/src/components/MessageContent.tsx file.

Summary

The MessageContent component is updated to wrap its content in a div element when the hasLoadingMessage prop is true. This is achieved by adding an as="div" prop to the Transition element within the MessageContent component.

Changes

  • Adds an as="div" prop to the Transition element when hasLoadingMessage is true.

@tianjing-li tianjing-li merged commit 6109c61 into main Jun 17, 2024
1 of 2 checks passed
@tianjing-li tianjing-li deleted the pia/transition-props branch June 17, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants