[backend] api_key not set for class methods #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-cohere
requested review from
EugeneLightsOn,
malexw,
scottmx81,
tianjing-li and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
=======================================
Coverage ? 87.51%
=======================================
Files ? 130
Lines ? 4390
Branches ? 0
=======================================
Hits ? 3842
Misses ? 548
Partials ? 0 ☔ View full report in Codecov by Sentry. |
tomtobac
approved these changes
Jun 11, 2024
EugeneLightsOn
approved these changes
Jun 11, 2024
tianjing-li
approved these changes
Jun 11, 2024
KevinLuong96
approved these changes
Jun 11, 2024
ClaytonSmith
pushed a commit
to MiniMap-ai/cohere-toolkit
that referenced
this pull request
Jun 11, 2024
* fix * easier fix
ClaytonSmith
added a commit
to MiniMap-ai/cohere-toolkit
that referenced
this pull request
Jun 17, 2024
* [coral-web] rename schema fields and update openapi client (cohere-ai#189) * update * update client * Add use agents view env variable. (cohere-ai#192) * Change * Format * [backend] api_key not set for class methods (cohere-ai#191) * fix * easier fix * perf: downgrade rehype-highlight and generate once blob url (cohere-ai#193) * perf: downgrade rehype-highlight and generate once blob url * fix: replace code blocks to iframe in conversation history * refactor: run format * refactor: pr feedback * Add OIDC auth strategy, add Blacklist scaffolding (model/schema/crud) (cohere-ai#190) * add oidc, blacklist logic * Add auth * Add logic for GET /auth * Mods * fix: html preview with citations (cohere-ai#200) * [backend] adding tools for agents, filter tools by agent_id (cohere-ai#204) * changes * lint * filter tools by agent * lint * update tests * lint and squash migrations * fix alembic migration err * lint * merge (#3) * [backend] make deployment field optional in API and DB (cohere-ai#213) --------- Co-authored-by: Tianjing Li <[email protected]> Co-authored-by: Tomeu <[email protected]> Co-authored-by: Scott <[email protected]> Co-authored-by: Beatrix De Wilde <[email protected]> * pulling from main * cleaned backend docker image push * syncing with main (conflicts) --------- Co-authored-by: Scott <[email protected]> Co-authored-by: Beatrix De Wilde <[email protected]> Co-authored-by: Tomeu <[email protected]> Co-authored-by: Tianjing Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
CohereDeploymentwhen we call the class methodlist_model()we don't actually have the API key set as a class attribute, rather it is set on__init__as a instance attribute. To fix this we can just set the API key at the class attribute level and both class and instance methods can both access it.The other deployment class definitions don't have this problem. They just have a list of the model as a class attribute.
Tested locally
AI Description
This pull request updates the
CohereDeploymentclass incohere_platform.pyto use theget_model_config_varfunction to retrieve the API key from the environment variableCOHERE_API_KEY_ENV_VAR.File Changes
src/backend/model_deployments/cohere_platform.pyCode Changes
api_keyattribute of theCohereDeploymentclass is now assigned using theget_model_config_varfunction, passing inCOHERE_API_KEY_ENV_VARas an argument.self.api_keyin the__init__method, as it is now assigned in the class definition.