-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth: Add Google OAuth #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's nothing that really jumps out at me here, though it should probably get a review from someone who's more familiar with the backend than me.
@EugeneLightsOn I've added this ticket: https://linear.app/cohereai/issue/EXT2-74/add-jwt-token-bearer-header-to-requests-remove-usage-of-session To track the work of removing session and using a JWT token based auth |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage ? 87.85%
=======================================
Files ? 116
Lines ? 3673
Branches ? 0
=======================================
Hits ? 3227
Misses ? 446
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🇮🇹
Note: OAuth not in usable state after merging this, will require JWT token
TODO: