Skip to content

UN-3676, UN-3680 Updates for Neuro UI to consume this library #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsargent merged 3 commits into from
Mar 17, 2026
Merged

UN-3676, UN-3680 Updates for Neuro UI to consume this library #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f3f967
UN-3676, UN-3680 Updates for Neuro UI to consume this library
dsargent Mar 17, 2026
b506dd0
UN-3676, UN-3680 Loosen up peer dependency
dsargent Mar 17, 2026
654a906
UN-3676, UN-3680 Commit lockfile
dsargent Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/main/pages/_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ export default function NeuroSanUI({Component, pageProps}: ExtendedAppProps): Re
if (!res.ok) {
// This is bad: it means we saw the ALB header, but it's not in the right format so we're stuck
console.error(`Failed to fetch user info: ${res.status} ${res.statusText}`)
return

@dsargent dsargent Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much point continuing if we got an error here. Also, now matches Neuro UI.

Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
}

const response: UserInfoResponse = await res.json()
Expand Down
2 changes: 1 addition & 1 deletion apps/main/pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ export default function Index(): ReactElement {
id="explore-agent-networks-link-anchor"
target="_blank"
rel="noopener noreferrer"
href={`/projects?${buildQueryString()}`}
href="#"
Comment thread
dsargent marked this conversation as resolved.

@dsargent dsargent Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dummy url.

@swensel swensel Mar 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just remove href here. Using # can add a hash to the URL. Not a huge issue, but removing the attribute is cleaner, IMO.

@dsargent dsargent Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is ignored -- only the outer Link URL is used for navigation. However, if we don't put something here, the styling is off as there's "no href" on the anchor item.

>
<LaunchButton id="neuro-san-button">Explore agent networks</LaunchButton>
</a>
Expand Down
32 changes: 19 additions & 13 deletions packages/ui-common/components/Common/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ export interface NavbarProps {

// Optional logo.dev token for customer branding
readonly logoServiceToken?: string

// Optional flag to show/hide the settings button, defaults to true

@dsargent dsargent Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that Neuro UI can opt-out of Settings...for now.

readonly showSettingsButton?: boolean
}

const MENU_ITEM_TEXT_PROPS = {
Expand All @@ -99,6 +102,7 @@ export const Navbar = ({
logoServiceToken,
pathname,
query,
showSettingsButton = true,
signOut,
supportEmailAddress,
userInfo,
Expand Down Expand Up @@ -452,19 +456,21 @@ export const Navbar = ({
/>
</Tooltip>
{/* Settings */}
<Tooltip title="Settings">
<SettingsIcon
sx={{
...MENU_ITEM_TEXT_PROPS,
marginRight: "1rem",
fontSize: "1rem",
cursor: "pointer",
}}
onClick={() => {
setSettingsDialogOpen(true)
}}
/>
</Tooltip>
{showSettingsButton && (
<Tooltip title="Settings">
<SettingsIcon
sx={{
...MENU_ITEM_TEXT_PROPS,
marginRight: "1rem",
fontSize: "1rem",
cursor: "pointer",
}}
onClick={() => {
setSettingsDialogOpen(true)
}}
/>
</Tooltip>
)}
</Grid>
) : (
<LoadingSpinner id="navbar-loading-spinner" />
Expand Down
2 changes: 2 additions & 0 deletions packages/ui-common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ limitations under the License.
* Export modules so they can be imported with simpler paths in the consumer
*/

export * from "./Theme/Theme"

@dsargent dsargent Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expose these so Neuro UI can use them.

export * from "./components/AgentChat/ChatCommon"
export * from "./components/AgentChat/ControlButtons"
export * from "./components/AgentChat/LlmChatButton"
Expand Down Expand Up @@ -49,6 +50,7 @@ export * from "./controller/agent/Agent"
export * from "./controller/llm/LlmChat"
export * from "./generated/neuro-san/NeuroSanClient"
export * from "./state/Environment"
export * from "./state/Settings"
export * from "./state/UserInfo"
export * from "./utils/Authentication"
export * from "./utils/text"
Expand Down
3 changes: 2 additions & 1 deletion packages/ui-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"jsonrepair": "3.8.0",
"lodash-es": "4.17.23",
"next": "16.1.6",
"next-auth": "5.0.0-beta.30",
"notistack": "3.0.2",
"react-dom": "19.2.4",
"react-markdown": "10.1.0",
Expand All @@ -43,7 +42,9 @@
"@emotion/styled": "^11.13.0",
"@mui/icons-material": "^7.3.1",
"@mui/material": "^7.3.1",
"@mui/system": "^7.3.1",

@dsargent dsargent Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make these peer deps for smoother integration with Neuro UI and others.

@swensel swensel Mar 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting an issue with the lockfile:

Screenshot 2026-03-17 at 2 57 05 PM

"@mui/x-tree-view": "^8.22.0",
"next-auth": "5.0.0-beta.30",
"react": "^19.2.4",
"react-dom": "^19.2.4",
"typescript": "^5.9.2"
Expand Down
3 changes: 2 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1639,7 +1639,6 @@ __metadata:
jsonrepair: "npm:3.8.0"
lodash-es: "npm:4.17.23"
next: "npm:16.1.6"
next-auth: "npm:5.0.0-beta.30"
notistack: "npm:3.0.2"
openapi-typescript: "npm:7.8.0"
react-dom: "npm:19.2.4"
Expand All @@ -1653,7 +1652,9 @@ __metadata:
"@emotion/styled": ^11.13.0
"@mui/icons-material": ^7.3.1
"@mui/material": ^7.3.1
"@mui/system": ^7.3.1
"@mui/x-tree-view": ^8.22.0
next-auth: 5.0.0-beta.30
react: ^19.2.4
react-dom: ^19.2.4
typescript: ^5.9.2
Expand Down
Loading