-
Notifications
You must be signed in to change notification settings - Fork 23
docs: allow classes and async/await in live examples #1543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1a6c826 to
1ab1472
Compare
Codecov Report
@@ Coverage Diff @@
## master #1543 +/- ##
==========================================
+ Coverage 64.04% 68.32% +4.28%
==========================================
Files 73 142 +69
Lines 1986 7079 +5093
Branches 166 775 +609
==========================================
+ Hits 1272 4837 +3565
- Misses 712 2236 +1524
- Partials 2 6 +4 |
|
📙 Documentation preview is available from |
|
Best. Thing. Ever |
| "npm-to-yarn": "^1.0.1", | ||
| "react": "^16.8.4", | ||
| "react-dom": "^16.8.4", | ||
| "react-live": "maksnester/react-live#mn/disable-transpilation-options-dist", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dafuc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. It's the branch ofc. Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@larsmoa Fair question. You can specify github repo#branch instead of the version number. In that case, during installation the package node_modules/react-live will be downloaded from github repo instead of NPM. That's a temporary hack until PR will be merged. I didn't want to create a fork of react-live under org and maintain it and publish it under new name. I just want my patch to work.
Once my referenced PR to react-live will be merged I'll update it here with new patched react-live version.
|
Approved, but hold the merge until I have released. |
basically, the fix for classes here is passing
transpileOptionstoLiveProviderasbut it's not supported in react-live (at least yet, but I made a PR hope to see it merged someday). Meanwhile, I just listed a github branch as a dependency so we can use it even before it's merged.