This repository has been archived by the owner on Feb 3, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
skipWaiting
parameter is set to true, allowing newlyregistered service worker to bypass the
waiting
state, so all out ofdate cache entries from the previous service worker will be deleted.
Because of async dynamic module loading we don't want that to happen,
keeping a way of loading old chunks.
The downside of removing skipWaiting is that newly deployed
service worker code and caches won't become active until all existing
tabs that have an older version of that service worker are closed, but
that actually sounds we want exactly this behaviour.
Related to
GoogleChromeLabs/sw-precache#180 (comment)
We can also provide users with a popup by click on which
skipWaiting()
will be called manually.Any thoughts on this?