Make Deploy/TearDown Provision methods asynchronous #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status is now reported back via Status messages sent into a channel returned by these methods. This removes user interface interaction from the provision plugin, allowing it to be performed by a remote (gRPC) plugin.
The high-level Execute* methods now use a provided status channel rather than returning one, and execute synchronously. This simplifies the code and allows us to use the main status channel in the SpireHelm provision plugin.
It should no longer be providing any direct UI interaction.
markgoddard
commented
Dec 6, 2024
Now that HelmSPIREProvider methods are synchronous, and multiple operations can be sent over a single status channel, we need to adapt the error handling to use a more traditional error return value.
Another provision plugin can now delegate certain actions to the SpireHelm provision plugin. A ProviderFactory interface allows for customising the HelmSPIREProvider construction.
jsnctl
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Deploy/TearDown asynchronous in Provision interface
Status is now reported back via Status messages sent into a channel
returned by these methods.
This removes user interface interaction from the provision plugin,
allowing it to be performed by a remote (gRPC) plugin.
Refactor HelmSPIREProvider methods to be synchronous
The high-level Execute* methods now use a provided status channel rather
than returning one, and execute synchronously. This simplifies the code
and allows us to use the main status channel in the SpireHelm provision
plugin.
Add StatusBuilder to simplify status reporting
Remove last Printf calls from helm package
It should no longer be providing any direct UI interaction.
Export SpireHelm methods to allow provision plugins to reuse them
Another provision plugin can now delegate certain actions to the
SpireHelm provision plugin.
A ProviderFactory interface allows for customising the HelmSPIREProvider
construction.
Add Helm provider interface and a spirehelm unit test
This is another step towards #56.