Fix wait_for_pong in integration tests #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wait_for_pong needs to return 1 when retries are exhausted in order to signal failure. The kubectl wait exit code was being ignored because wait_for_pong is called as an if conditional. Pull it out of wait_for_pong. Some context on the issue: https://stratus3d.com/blog/2019/11/29/bash-errexit-inconsistency/
nialdaly
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait_for_pong needs to return 1 when retries are exhausted in order to
signal failure.
The kubectl wait exit code was being ignored because wait_for_pong is
called as an if conditional. Pull it out of wait_for_pong. Some context
on the issue:
https://stratus3d.com/blog/2019/11/29/bash-errexit-inconsistency/