Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for Helm values generator #15

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Add unit tests for Helm values generator #15

merged 2 commits into from
Nov 14, 2024

Conversation

markgoddard
Copy link
Contributor

@markgoddard markgoddard commented Nov 13, 2024 •
edited
Loading

Related: #13

@markgoddard markgoddard self-assigned this Nov 13, 2024
@markgoddard markgoddard added this to the release-0.6.0 milestone Nov 13, 2024
nialdaly
nialdaly approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@nialdaly nialdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👌

@markgoddard markgoddard merged commit 536cd1c into main Nov 14, 2024
3 checks passed
@markgoddard markgoddard deleted the values-tests branch November 14, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nialdaly nialdaly nialdaly approved these changes

@mattbates mattbates Awaiting requested review from mattbates

@jsnctl jsnctl Awaiting requested review from jsnctl

Assignees

@markgoddard markgoddard

Labels
None yet
Projects
None yet
Milestone
release-0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@markgoddard @nialdaly