Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing port from ping-pong-mesh client #10

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

jsnctl
Copy link
Contributor

@jsnctl jsnctl commented Dec 19, 2024

FederatedService handles the port to the upstream workload as part of the targetPort of the ServiceEntry, so we don't need to add this as part of the calling address

@jsnctl jsnctl added this to the release-0.8.0 milestone Dec 19, 2024
@jsnctl jsnctl self-assigned this Dec 19, 2024
@jsnctl jsnctl changed the base branch from main to jsnctl/cofide-sdk-demo December 19, 2024 14:25
@jsnctl jsnctl changed the base branch from jsnctl/cofide-sdk-demo to main December 19, 2024 14:25
@jsnctl jsnctl marked this pull request as ready for review December 19, 2024 14:26
@jsnctl jsnctl merged commit fae96c5 into main Dec 19, 2024
2 checks passed
@jsnctl jsnctl deleted the jsnctl/remove-port-from-mesh-client branch December 19, 2024 15:10
@markgoddard
Copy link
Contributor

FederatedService handles the port to the upstream workload as part of the targetPort of the ServiceEntry, so we don't need to add this as part of the calling address

Let's keep in mind the use case of a single cluster without federated services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants