Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reply request for co-occurred articles that are not replied yet #398

Merged
merged 8 commits into from
Oct 21, 2024

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Sep 15, 2024

Fixes #396

  • Whenever LINE bot adds cooccurrences, also add reply request for the co-occurred articles that are not replied yet
    • This implies adding replyCount to queries, and thus adds many code changes for related fixtures
  • Add unit test for askingCooccurrence
    • We did not add unit test when we implemented it earlier this year
  • Fix the bug that media file whose transcript has high tf-idf score will be included in co-occurrence incorrectly
    • We fix this by sorting searchMedia result, which has a universal effect on image search results also

@coveralls
Copy link

coveralls commented Sep 15, 2024

Pull Request Test Coverage Report for Build 11434927359

Details

  • 9 of 10 (90.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.2%) to 90.535%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/webhook/handlers/askingArticleSubmissionConsent.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 10927118708: 3.2%
Covered Lines: 1080
Relevant Lines: 1153

💛 - Coveralls

@MrOrz MrOrz marked this pull request as ready for review September 15, 2024 20:08
@MrOrz MrOrz self-assigned this Sep 15, 2024
Base automatically changed from aticle-createdat to master September 18, 2024 17:24
…d score second

- This aligns with the fact that searchText also sorts by itself
- processMedia snapshot affected
- we can then use first edge of search result as perfect match, no need for extractExactMatchFromEachSearchResult
@MrOrz MrOrz merged commit 642995f into master Oct 21, 2024
9 checks passed
@MrOrz MrOrz deleted the cooccurrence-replyrequest branch October 21, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create empty Reply Request when setting cooccurrences
4 participants