-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve on the build process of this module #92
Conversation
8bb1a05
to
b9f2495
Compare
b9f2495
to
398426b
Compare
@codypiersall I saw the smoketest failing and updated the PR again. Instead of subclassing If you have the time I can recommend this blogpost on the current state of python packaging. |
2c08960
to
f614c47
Compare
Adds a builder class for building mbedtls and nng. Add custom build option to build nng/mbedtls (hardcoded: 'yes') Uses setup.cfg to specify the repo url and revision
f614c47
to
f090013
Compare
@codypiersall try again? |
Hey @leonardp, I really appreciate the time you've taken on this and I do like the approach. Unfortunately some stuff in my personal life recently blew up (thankfully not involving health or family) so I do not know when I will have time to look at this in depth. |
Hello @codypiersall, I hope you are (doing) well. |
@leonardp, I was a poetry user for a while (personally and professionally) and really like the project, but it has some shortcomings that ultimately pushed me back to setuptools. Namely, lack of support for editable installs and lack of support for PEP 621. It's possible that neither of these are deal-breakers for pynng, but I'd personally recommend a build system with a better track record of standards adherence (e.g. flit, pdm, or of course (as of very recently) setuptools. |
Took me over a year from the initial PR, but I finally merged this. Your PR is way better than what I was doing before, so thank you! |
Adds a builder class for building mbedtls and nng.
Uses setup.cfg to specify the repo url and revision.
This should fix #1 and can be a step to solve #10 as well.